Date: Tue, 15 Feb 2022 21:33:32 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: Column Filtering in Logical Replication
Message-ID: <202202160033.suwczmeq7mjf@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d37d6709-7e9c-f422-f925-fa66ce1fc0e8@enterprisedb.com>
Archived-At: <https://www.postgresql.org/message-id/202202160033.suwczmeq7mjf%40alvherre.pgsql>
Precedence: bulk

On 2022-Feb-16, Tomas Vondra wrote:

> Here's an updated version of the patch, rebased to current master. Parts
> 0002 and 0003 include various improvements based on review by me and another
> one by Peter Smith [1].

Thanks for doing this!

> 1) partitioning with pubviaroot=true

I agree that preventing the inconsistencies from happening is probably
the best.

> 2) merging multiple column filters
> 
> When the table has multiple column filters (in different publications), we
> need to merge them. Which works, except that FOR ALL TABLES [IN SCHEMA]
> needs to be handled as "has no column filter" (and replicates everything).

Agreed.

> 3) partitioning with pubivaroot=false
> 
> When a partitioned table is added with (pubviaroot=false), it should not be
> subject to column filter on the parent relation, which is the same behavior
> used by the row filtering patch.

You mean each partition should define its own filter, or lack of filter?
That sounds reasonable.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Pensar que el espectro que vemos es ilusorio no lo despoja de espanto,
sólo le suma el nuevo terror de la locura" (Perelandra, C.S. Lewis)