Date: Tue, 15 Feb 2022 23:57:56 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Michael Paquier <michael@paquier.xyz>
Subject: Re: make tuplestore helper function
Message-ID: <20220216055756.GD31460@telsasoft.com>
References: <20211102202353.GG17618@telsasoft.com>
 <CAAKRu_a-ZZTez9yn4EMDAQQgt1UFpFcTVr=MDxf-b75tZ9q8UQ@mail.gmail.com>
 <20211108201338.GU17618@telsasoft.com>
 <CAAKRu_b2rySeOC=zZDd-++N6AXTuL-uABpPKQgO8f2NV4j5dPw@mail.gmail.com>
 <20211118182430.GO17618@telsasoft.com>
 <CAAKRu_aQDmqRmDLE4qPSL-b0cPQA-ELkfkSBWtLgV6Y1Zp6yBQ@mail.gmail.com>
 <20211217200419.GQ17618@telsasoft.com>
 <CAAKRu_a5rBP2XV9JU9CtD=KB0GySXCJRDSramrVbW=LPMro_eA@mail.gmail.com>
 <20220106005748.GT14051@telsasoft.com>
 <CAAKRu_b-W8BqK6x57sqm=RfivGuU0=fHF9urv9_3onAMZT3r=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAAKRu_b-W8BqK6x57sqm=RfivGuU0=fHF9urv9_3onAMZT3r=w@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220216055756.GD31460%40telsasoft.com>
Precedence: bulk

On Tue, Jan 11, 2022 at 10:19:33AM -0500, Melanie Plageman wrote:
> > If the expectedDesc NULL check were an 0001 patch, then 0002 (the main patch)
> > would be even easier to review.  Only foreign.c is different.
> 
> I'll wait to do that if preferred by committer.
> Are you imagining that patch 0001 would only add the check for
> expectedDesc that is missing from pg_config() and text_to_table()?

Yes, that's what I meant, but I haven't been able to determine if a NULL check
should be added at all.

I found this commit message, which indicates that it shouldn't be used in every
case.  I'm not clear when it should/not be used, though.

commit 60651e4cddbb77e8f1a0c7fc0be6a7e7bf626fe0
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Sat Oct 28 14:02:21 2017 -0400

    Support domains over composite types in PL/Perl.
    
    In passing, don't insist on rsi->expectedDesc being set unless we
    actually need it; this allows succeeding in a couple of cases where
    PL/Perl functions returning setof composite would have failed before,
    and makes the error message more apropos in other cases.