Date: Mon, 21 Feb 2022 08:52:28 -0800
From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson
Message-ID: <20220221165228.aqnfg45mceym7njm@alap3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <aa45e007-4b28-1582-1d91-1d88cdf28524@enterprisedb.com>
 <20211012161541.b3udjnblk6z4zc5u@alap3.anarazel.de>
 <20211012190122.hkdcrmvafj3eihpx@alap3.anarazel.de>
 <62A6B9F0-C3D3-45CD-8E8B-90A8E5B08DFA@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <62A6B9F0-C3D3-45CD-8E8B-90A8E5B08DFA@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/20220221165228.aqnfg45mceym7njm%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-10-13 13:54:10 +0200, Daniel Gustafsson wrote:
> I added a --tap option for TAP output to pg_regress together with Jinbao Chen
> for giggles and killing some time a while back.

Sorry for not replying to this earlier. I somehow thought I had, but the
archives disagree.

I think this would be great.


> If it's helpful and there's any interest for this I'm happy to finish it up now.

Yes!  Probably worth starting a new thread for...


> One thing that came out of this, is that we don't really handle the ignored
> tests in the way the code thinks it does for normal output, the attached treats
> ignored tests as SKIP tests.

I can't really parse the first sentence...


>  	if (exit_status != 0)
>  		log_child_failure(exit_status);
> @@ -2152,6 +2413,7 @@ regression_main(int argc, char *argv[],
>  		{"config-auth", required_argument, NULL, 24},
>  		{"max-concurrent-tests", required_argument, NULL, 25},
>  		{"make-testtablespace-dir", no_argument, NULL, 26},
> +		{"tap", no_argument, NULL, 27},
>  		{NULL, 0, NULL, 0}
>  	};

I'd make it a --format=(regress|tap) or such.

Greetings,

Andres Freund