Date: Wed, 23 Feb 2022 13:16:06 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org
Subject: Re: convert libpq uri-regress tests to tap test
Message-ID: <20220223211606.ikcwoolsz2nohsw6@alap3.anarazel.de>
References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de>
 <0b8719b8-f339-ebc0-781a-737db158b671@dunslane.net>
 <1251254.1645649828@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1251254.1645649828@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20220223211606.ikcwoolsz2nohsw6%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-02-23 15:57:08 -0500, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > On 2/23/22 15:30, Andres Freund wrote:
> >> Perhaps we should just rename src/test/modules/libpq_pipeline to
> >> src/test/modules/libpq and move uri-regress in there as well?
> 
> > WFM
> 
> +1

Cool.


One question on making that happen: Right now the makefiles building C stuff
in src/test/modules all have the contrib-style stanza to build via pgxs.  But
afaics pgxs doesn't support building multiple programs. Which
src/test/modules/libpq would need to.

Aaics there's currently no way to have Mkvcbuild.pm build multiple programs in
one dir via its makefile parsing stuff? Andrew, any suggestions for not
needing to spell this out in both the makefile and Mkvcbuild.pm?


Separately: I don't really understand why we do the whole if USE_PGXS dance in
src/test/modules?

- Andres