Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzTE-0004wI-H8 for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Feb 2022 21:46:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nMzTC-0002Bs-Il for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Feb 2022 21:46:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzTC-0002BP-9T for pgsql-hackers@lists.postgresql.org; Wed, 23 Feb 2022 21:46:46 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzT5-0000zQ-Ez for pgsql-hackers@postgresql.org; Wed, 23 Feb 2022 21:46:45 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 524333201DA0; Wed, 23 Feb 2022 16:46:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 23 Feb 2022 16:46:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=QmH7vSm+pwbZ6jsuMjUEwmERcIAq6FF1FtF9FU+RXcM=; b=arysdCrJ 4UMyf5fAHYA+tAVuYh09C1dOG4EiLDuN6DInv/831f5tOI+wV1J8LqI8GYrZ/9XH PfNMLOdKhP+n3ZLi3bG76nHMhNCLX9/XvnshGBnhdgja5RuvXqlnF3NoL1BqGJf7 dLeYDFPEVKS3JJMBsnhiLO3r7T2KOKmiyZUgsCq6cPOMvVkqLYlxXRGGrgVlcTC8 UZGRmb8iRI6iipRlTiSHK/K2XZzPHKD+6x9odVA4gW0Ko3Oo0+K2unaecwnyXbnv vvqPUBTJc6BA344Vao1xld2zBpnaK+6Mq5aOoCBbFJUYh2PqaNTRVYVfY1s00SIS DFfQ3nywBPo0iQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 16:46:36 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 1FAF12A6917; Wed, 23 Feb 2022 18:46:34 -0300 (-03) Date: Wed, 23 Feb 2022 18:46:34 -0300 From: Alvaro Herrera To: Andres Freund Cc: Tom Lane , Andrew Dunstan , pgsql-hackers@postgresql.org Subject: Re: convert libpq uri-regress tests to tap test Message-ID: <202202232146.xkrt7kmtbwde@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220223211606.ikcwoolsz2nohsw6@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Feb-23, Andres Freund wrote: > Separately: I don't really understand why we do the whole if USE_PGXS dance in > src/test/modules? Yeah, it seems a bit silly. I'm not opposed to making these makefiles unconditionally do the PGXS thing -- or the non-PGXS thing, if that makes it easier to build multiple binaries. -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "La grandeza es una experiencia transitoria. Nunca es consistente. Depende en gran parte de la imaginación humana creadora de mitos" (Irulan)