Date: Thu, 24 Feb 2022 16:26:42 +0900 (JST)
Message-Id: <20220224.162642.47104618503429482.horikyota.ntt@gmail.com>
To: simseih@amazon.com
Cc: alvherre@alvh.no-ip.org, pgsql-hackers@postgresql.org
Subject: Re: [BUG] Panic due to incorrect missingContrecPtr after promotion
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <B0FE9B0D-E5B6-4515-B191-1C041411D339@amazon.com>
References: <44D259DE-7542-49C4-8A52-2AB01534DCA9@amazon.com>
	<202202222016.3nar64wc7xs7@alvherre.pgsql>
	<B0FE9B0D-E5B6-4515-B191-1C041411D339@amazon.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20220224.162642.47104618503429482.horikyota.ntt%40gmail.com>
Precedence: bulk

At Wed, 23 Feb 2022 02:58:07 +0000, "Imseih (AWS), Sami" <simseih@amazon.com> wrote in 
> >    Ooh, nice find and diagnosys.  I can confirm that the test fails as you
> >    described without the code fix, and doesn't fail with it.
> 
> >    I attach the same patch, with the test file put in its final place
> >    rather than as a patch.  Due to recent xlog.c changes this need a bit of
> >    work to apply to back branches; I'll see about getting it in all
> >    branches soon.
> 
> Thank you for reviewing!

Nice catch!  However, I'm not sure I like the patch.

 	 * made it through and start writing after the portion that persisted.
 	 * (It's critical to first write an OVERWRITE_CONTRECORD message, which
 	 * we'll do as soon as we're open for writing new WAL.)
+	 *
+	 * If the last wal record is ahead of the missing contrecord, this is a
+	 * recently promoted primary and we should not write an overwrite
+	 * contrecord.

Before the part, the comment follows the part shown below.

>	 * Actually, if WAL ended in an incomplete record, skip the parts that

So, actually WAL did not ended in an incomplete record.  I think
FinishWalRecover is the last place to do that. (But it could be
earlier.)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center