Date: Thu, 24 Feb 2022 14:00:26 +0900
From: KAWAMOTO Masaya <kawamoto@sraoss.co.jp>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Typo in pgbench messages.
Message-Id: <20220224140026.1073bf41bb59fc4f07446fee@sraoss.co.jp>
In-Reply-To: <20220224.121555.603427016970782829.t-ishii@sranhm.sra.co.jp>
References: <20220224115622.41e671e3449ebd8c270e9103@sraoss.co.jp>
	<20220224.121555.603427016970782829.t-ishii@sranhm.sra.co.jp>
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="Multipart=_Thu__24_Feb_2022_14_00_26_+0900_y62/JFeltvRRKNoL"
Archived-At: <https://www.postgresql.org/message-id/20220224140026.1073bf41bb59fc4f07446fee%40sraoss.co.jp>
Precedence: bulk

This is a multi-part message in MIME format.

--Multipart=_Thu__24_Feb_2022_14_00_26_+0900_y62/JFeltvRRKNoL
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Thanks for your comment!

Sorry, I did not attach the patch file.
This patch focas on master branch.

Best regards,

On Thu, 24 Feb 2022 12:15:55 +0900 (JST)
Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> > Hi,
> > 
> > I found messages inserted a space before the "%" in pgbench.
> > I think this is typo because there are no space before the "%" in other messages.
> > What do you think? 
> 
> I think you are right. In English there's should be no space between number and "%".
> AFAIK other parts of PostgreSQL follow the rule.
> 
> > diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
> > index f166a77e3a..4ebe5e6ea4 100644
> > --- a/src/bin/pgbench/pgbench.c
> > +++ b/src/bin/pgbench/pgbench.c
> > @@ -5598,11 +5598,11 @@ printResults(StatsData *total,
> >  		return;
> >  
> >  	if (throttle_delay && latency_limit)
> > -		printf("number of transactions skipped: " INT64_FORMAT " (%.3f %%)\n",
> > +		printf("number of transactions skipped: " INT64_FORMAT " (%.3f%%)\n",
> >  			   total->skipped, 100.0 * total->skipped / total->cnt);
> >  
> >  	if (latency_limit)
> > -		printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f %%)\n",
> > +		printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f%%)\n",
> >  			   latency_limit / 1000.0, latency_late, ntx,
> >  			   (ntx > 0) ? 100.0 * latency_late / ntx : 0.0);
> 
> Looks good to me.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
> 
> 

-- 
KAWAMOTO Masaya <kawamoto@sraoss.co.jp>
SRA OSS, Inc. Japan

--Multipart=_Thu__24_Feb_2022_14_00_26_+0900_y62/JFeltvRRKNoL
Content-Type: application/octet-stream;
 name="typo_in_pgbench_messages.patch"
Content-Disposition: attachment;
 filename="typo_in_pgbench_messages.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMvYmluL3BnYmVuY2gv
cGdiZW5jaC5jCmluZGV4IGYxNjZhNzdlM2EuLjRlYmU1ZTZlYTQgMTAwNjQ0Ci0tLSBhL3NyYy9i
aW4vcGdiZW5jaC9wZ2JlbmNoLmMKKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYwpAQCAt
NTU5OCwxMSArNTU5OCwxMSBAQCBwcmludFJlc3VsdHMoU3RhdHNEYXRhICp0b3RhbCwKIAkJcmV0
dXJuOwogCiAJaWYgKHRocm90dGxlX2RlbGF5ICYmIGxhdGVuY3lfbGltaXQpCi0JCXByaW50Zigi
bnVtYmVyIG9mIHRyYW5zYWN0aW9ucyBza2lwcGVkOiAiIElOVDY0X0ZPUk1BVCAiICglLjNmICUl
KVxuIiwKKwkJcHJpbnRmKCJudW1iZXIgb2YgdHJhbnNhY3Rpb25zIHNraXBwZWQ6ICIgSU5UNjRf
Rk9STUFUICIgKCUuM2YlJSlcbiIsCiAJCQkgICB0b3RhbC0+c2tpcHBlZCwgMTAwLjAgKiB0b3Rh
bC0+c2tpcHBlZCAvIHRvdGFsLT5jbnQpOwogCiAJaWYgKGxhdGVuY3lfbGltaXQpCi0JCXByaW50
ZigibnVtYmVyIG9mIHRyYW5zYWN0aW9ucyBhYm92ZSB0aGUgJS4xZiBtcyBsYXRlbmN5IGxpbWl0
OiAiIElOVDY0X0ZPUk1BVCAiLyIgSU5UNjRfRk9STUFUICIgKCUuM2YgJSUpXG4iLAorCQlwcmlu
dGYoIm51bWJlciBvZiB0cmFuc2FjdGlvbnMgYWJvdmUgdGhlICUuMWYgbXMgbGF0ZW5jeSBsaW1p
dDogIiBJTlQ2NF9GT1JNQVQgIi8iIElOVDY0X0ZPUk1BVCAiICglLjNmJSUpXG4iLAogCQkJICAg
bGF0ZW5jeV9saW1pdCAvIDEwMDAuMCwgbGF0ZW5jeV9sYXRlLCBudHgsCiAJCQkgICAobnR4ID4g
MCkgPyAxMDAuMCAqIGxhdGVuY3lfbGF0ZSAvIG50eCA6IDAuMCk7CiAK

--Multipart=_Thu__24_Feb_2022_14_00_26_+0900_y62/JFeltvRRKNoL--