Date: Thu, 24 Feb 2022 06:45:38 -0800
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Design of pg_stat_subscription_workers vs pgstats
Message-ID: <20220224144538.42wizqk4hxdepe5a@alap3.anarazel.de>
References: <20220221053453.lo6fzmji23ennvgj@alap3.anarazel.de>
 <CAA4eK1+j00Pc+p=AfJLXh-a+OJ-a0UD4adMr2tRkQvKG_LggHA@mail.gmail.com>
 <20220221074806.nyhdberpuwbcbudp@alap3.anarazel.de>
 <CAA4eK1J3dhfMRNQ6Q585nFr1vmXaTXVW9qv4hmUxLwDwJp-9RQ@mail.gmail.com>
 <CAD21AoAtrgBEUU08VvfzRnGS+=9rS=MEq1cTLaZ1OT51xX34dQ@mail.gmail.com>
 <CAHut+PtH-uN5rbGRh-=kCd8xvQYDf_JCcjLcVjW3OXGz6T+xCw@mail.gmail.com>
 <CAD21AoCCaQfGzDCAJgYH=yo72GXozpoMF4fau=5gViXK+uquWw@mail.gmail.com>
 <6f7701b0-ce5c-d01c-18f2-5de3a02ff6b6@enterprisedb.com>
 <CAD21AoBstze6x4zCXrSp_PppO_8M-s8L7PK7GsJahMmjQXSC+Q@mail.gmail.com>
 <ca9f44f0-a553-2f57-8017-d0ad84e06a6a@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ca9f44f0-a553-2f57-8017-d0ad84e06a6a@enterprisedb.com>
Archived-At: <https://www.postgresql.org/message-id/20220224144538.42wizqk4hxdepe5a%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-02-24 13:23:55 +0100, Peter Eisentraut wrote:
> On 24.02.22 12:46, Masahiko Sawada wrote:
> > > We have a view called pg_stat_activity, which is very well known.  From
> > > that perspective, "activity" means what is happening right now or what
> > > has happened most recently.  The reworked view in this patch does not
> > > contain that (we already have pg_stat_subscription for that), but it
> > > contains accumulated counters.
> > Right.
> > 
> > What pg_stat_subscription shows is rather suitable for the name
> > pg_stat_subscription_activity than the reworked view. But switching
> > these names would also not be a good idea.  I think it's better to use
> > "subscription" in the view name since it shows actually statistics for
> > subscriptions and subscription OID is the key. I personally prefer
> > pg_stat_subscription_counters among the ideas that have been proposed
> > so far, but I'd like to hear opinions and votes.
> 
> _counters will fail if there is something not a counter (such as
> last-timestamp-of-something).
> 
> Earlier, pg_stat_subscription_stats was mentioned, which doesn't have that
> problem.

We really should try to fix this in a more general way at some point. We have
way too many different things mixed up in pg_stat_*.

I'd like to get something like the patch in soon though, we can still change
the name later. I've been blocked behind this stuff for weeks, and it's
getting really painful...

Greetings,

Andres Freund