Date: Fri, 25 Feb 2022 13:23:49 -0800
From: Andres Freund <andres@anarazel.de>
To: Jacob Champion <pchampion@vmware.com>
Cc: "rjuju123@gmail.com" <rjuju123@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	"michael@paquier.xyz" <michael@paquier.xyz>,
	"sfrost@snowman.net" <sfrost@snowman.net>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Message-ID: <20220225212349.gf76klktl4dmm5ah@alap3.anarazel.de>
References: <793d990837ae5c06a558d58d62de9378ab525d83.camel@vmware.com>
 <YhduhD/SvIX5NnxY@paquier.xyz>
 <2e28b12b450f247d5c0994207030c862263e0297.camel@vmware.com>
 <20220224171538.jbf2cxzmhiwuinp4@jrouhaud>
 <a4d9baa0717ca924331cb1dd062788bd73bd14a4.camel@vmware.com>
 <d15d02c92a3e4bdb7cc7b96b0abfe97f213e4445.camel@vmware.com>
 <cdbcf8653e56340f73438e647ea5a26f021627ed.camel@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cdbcf8653e56340f73438e647ea5a26f021627ed.camel@vmware.com>
Archived-At: <https://www.postgresql.org/message-id/20220225212349.gf76klktl4dmm5ah%40alap3.anarazel.de>
Precedence: bulk

On 2022-02-25 20:19:24 +0000, Jacob Champion wrote:
> From 2fde60a6bc3739f1894c8c264120e4fa0f04df64 Mon Sep 17 00:00:00 2001
> From: Jacob Champion <pchampion@vmware.com>
> Date: Mon, 14 Feb 2022 08:10:53 -0800
> Subject: [PATCH v3] Add API to retrieve authn_id from SQL

> The authn_id field in MyProcPort is currently only accessible to the
> backend itself.  Add a SQL function, session_authn_id(), to expose the
> field to triggers that may want to make use of it.

Looks to me like authn_id isn't synchronized to parallel workers right now. So
the function will return the wrong thing when executed as part of a parallel
query.

I don't think we should add further functions not prefixed with pg_.


Perhaps a few tests for less trivial authn_ids could be worthwhile?
E.g. certificate DNs.

Greetings,

Andres Freund