Date: Sat, 26 Feb 2022 14:08:32 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Chapman Flack <chap@anastigmatix.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <20220226220832.GB673898@nathanxps13>
References: <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <20220221172306.GA3698472@nathanxps13>
 <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>
 <621AA398.4080206@anastigmatix.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <621AA398.4080206@anastigmatix.net>
Archived-At: <https://www.postgresql.org/message-id/20220226220832.GB673898%40nathanxps13>
Precedence: bulk

On Sat, Feb 26, 2022 at 05:03:04PM -0500, Chapman Flack wrote:
> I've now looked through the rest, and the only further thing I noticed
> was that xlog.c's do_pg_start_backup still has a tablespaces parameter
> to receive a List* of tablespaces if the caller wants, but this patch
> removes the comment describing it:
> 
> 
> - * If "tablespaces" isn't NULL, it receives a list of tablespaceinfo structs
> - * describing the cluster's tablespaces.
> 
> 
> which seems like collateral damage.

Thanks.  I will fix this and the proofreading nits you noted upthread in
the next revision.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com