public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix a typo in pg_receivewal.c's get_destination_dir()
Date: Sat, 26 Feb 2022 16:46:37 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACUT0C2LQwhyLXTQdj8T9SxZa5j7cmu-UOz0cZ8_D5edjg@mail.gmail.com>
References: <CALj2ACUT0C2LQwhyLXTQdj8T9SxZa5j7cmu-UOz0cZ8_D5edjg@mail.gmail.com>

Hi,

On 2022-02-26 22:04:13 +0530, Bharath Rupireddy wrote:
> It looks like there's a typo in pg_receivewal.c's
> get_destination_dir(), that is, use the function parameter dest_folder
> instead of global variable basedir in the error message. Although
> there's no harm in it as basedir is a global variable in
> pg_receivewal.c, let's use the function parameter to be in sync with
> close_destination_dir.
> 
> Attaching a tiny patch to fix it.

Good catch, pushed.

Greetings,

Andres Freund

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix a typo in pg_receivewal.c's get_destination_dir()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox