Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOl7M-0007L4-FK for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Feb 2022 18:51:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nOl7J-0007tR-Hp for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Feb 2022 18:51:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOl7J-0007tH-7T for pgsql-hackers@lists.postgresql.org; Mon, 28 Feb 2022 18:51:29 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nOl7E-0005Qq-8C for pgsql-hackers@postgresql.org; Mon, 28 Feb 2022 18:51:28 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 132so12333183pga.5 for ; Mon, 28 Feb 2022 10:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5E8K+1Eb14AOs7Hr8DD2ro8lma7hg1L0Kjgv3y3IXjk=; b=lzLJxcx0n4WMx06uWNTUVSrIlCTKG2IJXhBXq4yytx0MMc+9xV9Qzoyf5DoWPvg+Oi s+k2CRLgkeIdTvgcBEYQd7mW48SQUur4VEi1bjFfNgFDiNgqsR02b3zyAiczfsmzcXc0 SySLUgLJ38RBl33cwM8uGb5OZF7fSKgONIp4vA/4Bg+TrlHKacZVmeZFV4rOQ1uikg// WIdpQ27hRFh0ocdfG20/MgFoDeluzT8gRHe7ylsfZzaiBwVYIm2Otj/JO2eMp7Dj4xsK 6pmUFoPj0rA0Jd+MpyevJdoq0nDu85zj76wV0K0ONQZmBQ1g8wq0fkBcUqkrYmcyQJJR kIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5E8K+1Eb14AOs7Hr8DD2ro8lma7hg1L0Kjgv3y3IXjk=; b=l7rimYLaB/qcjPLQU3ahqo/Tu87hE0ThHUppuHOC0DDp1nMeuQMzXeMYsbrOgRE5uh q7aG+h8zPwNdJ4fspTpIUxsjdFFjMMMX5zivAOpIue/soeR/o8ZnqvOLS73pC9Wla6xJ qEiLE4kq/Y/Z26R/AN4I+j4JI41XWmvwHME6HLBZ6H4Rd4NbifNpNuA7irLQTIaxW24u QUjvOqFJK15tXWuYrFmBJKVXtjAF+KsQDG8CZNgEPly8NTKzC5+XwcbobMOT6zDseYuY 25NywTVcr12SQQ5fYk2k98YrGgjrQzk0IYghTOuZ8RMGNsl/O7oWVNiIga9cHfhOeN7Z QzTg== X-Gm-Message-State: AOAM530yW+QIdwamKhK9RwM0TkE1cufUiv+Wb0/89LQfZrER/noC9uBN l+/5a5y/1WxCwE5Zb+5WSKw= X-Google-Smtp-Source: ABdhPJyPxjPxPr1RLMaVv/mo6K/13AtAgd0APO1AvnZxWp2kpTgDkQ9sSHYRG88OuiYAKcnUqbjz1w== X-Received: by 2002:a63:be0c:0:b0:373:9f38:928e with SMTP id l12-20020a63be0c000000b003739f38928emr18228643pgf.241.1646074282848; Mon, 28 Feb 2022 10:51:22 -0800 (PST) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id n22-20020a056a0007d600b004f3ba7c23e2sm14320925pfu.37.2022.02.28.10.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 10:51:22 -0800 (PST) Date: Mon, 28 Feb 2022 10:51:21 -0800 From: Nathan Bossart To: Peter Eisentraut Cc: "Bossart, Nathan" , pgsql-hackers Subject: Re: parse/analyze API refactoring Message-ID: <20220228185121.GA944837@nathanxps13> References: <72519c4f-ebd8-b796-8216-1e6213fc1cf1@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72519c4f-ebd8-b796-8216-1e6213fc1cf1@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote: > You set this commit fest entry to Waiting on Author, but there were no > reviews posted and the patch still applies and builds AFAICT, so I don't > know what you meant by that. Apologies for the lack of clarity. I believe my only feedback was around deduplicating the pg_analyze_and_rewrite_*() functions. Would you rather handle that in a separate patch? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com