Date: Tue, 1 Mar 2022 07:10:49 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Chapman Flack <chap@anastigmatix.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <20220301151049.GB1030078@nathanxps13>
References: <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <20220221172306.GA3698472@nathanxps13>
 <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>
 <20220226220614.GA673898@nathanxps13>
 <20220301055100.GA1002387@nathanxps13>
 <e6657efe-f7b1-0894-9807-453c01bad81a@pgmasters.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e6657efe-f7b1-0894-9807-453c01bad81a@pgmasters.net>
Archived-At: <https://www.postgresql.org/message-id/20220301151049.GB1030078%40nathanxps13>
Precedence: bulk

On Tue, Mar 01, 2022 at 08:44:51AM -0600, David Steele wrote:
> Personally, I am in favor of removing it. We change/rename
> functions/tables/views when we need to, and this happens in almost every
> release.
> 
> What we need to do is make sure that an older installation won't silently
> work in a broken way, i.e. if we remove the exclusive flag somebody
> expecting the pre-9.6 behavior might not receive an error and think
> everything is OK. That would not be good.
> 
> One option might be to rename the functions. Something like
> pg_backup_start/stop.

I'm fine with this approach.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com