Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP5Xc-00026a-SZ for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 16:40:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nP5Xb-0001Jn-Fc for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 16:39:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP5Xb-0001JV-5c for pgsql-hackers@lists.postgresql.org; Tue, 01 Mar 2022 16:39:59 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nP5XY-000753-Ds for pgsql-hackers@lists.postgresql.org; Tue, 01 Mar 2022 16:39:57 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id B5D685F7A2; Tue, 1 Mar 2022 11:39:55 -0500 (EST) Date: Tue, 1 Mar 2022 11:39:55 -0500 From: Stephen Frost To: Nathan Bossart Cc: David Steele , Chapman Flack , pgsql-hackers@lists.postgresql.org Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file Message-ID: <20220301163955.GU10577@tamriel.snowman.net> References: <20220221172306.GA3698472@nathanxps13> <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org> <20220226220614.GA673898@nathanxps13> <20220301055100.GA1002387@nathanxps13> <20220301151049.GB1030078@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="67BqmJg2unxe7d8V" Content-Disposition: inline In-Reply-To: <20220301151049.GB1030078@nathanxps13> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --67BqmJg2unxe7d8V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Nathan Bossart (nathandbossart@gmail.com) wrote: > On Tue, Mar 01, 2022 at 08:44:51AM -0600, David Steele wrote: > > Personally, I am in favor of removing it. We change/rename > > functions/tables/views when we need to, and this happens in almost every > > release. > >=20 > > What we need to do is make sure that an older installation won't silent= ly > > work in a broken way, i.e. if we remove the exclusive flag somebody > > expecting the pre-9.6 behavior might not receive an error and think > > everything is OK. That would not be good. > >=20 > > One option might be to rename the functions. Something like > > pg_backup_start/stop. >=20 > I'm fine with this approach. +1. Thanks, Stephen --67BqmJg2unxe7d8V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJiHkxbAAoJEO1sijiDR2RV4WwP/RzcGiDWhDCRw0e5fX8xoPGQ 5DKpYLNZlDdMQO8Fvr+MEol8inA9Yp90et3Ncf3AuLA+vnG60DqK7fJFAIEre3xn lLEEHzhHVtrT6KeH4Q893PM+c8qGfa+JTG5guBlPAS7w4xN1rFt71xMhMvbnFNZ2 IlJx4A5BUBmkWuBKAnwZbHvrGKH5/vLkPZPzHfRmxkuFWf7nKqcq6D/YgbNgijZ/ 3sVOWrOPCACLrxZ+K4H1/BUroZ4tTOdKP6b6SI2t1z14aR8wPA5GaJqNolsRAdYn Mq3CLBJLs0j5hKJJlr5BzoHYst350wySeTt8DR0sNb7+AkxpViJYMYkSTDgz0F5f lTZ1r8wsH/p6MpMCzQ/ha5YeZb50mAElZBWWQH6BHoihUXUUAZmCfMzHobhaFlSa RRriOVtkzsn6xlJamGlhFOT7rbZLI1a8xOso6nK21ELMpV+qiIhGWJ+ksPbhzRFi PCC3KsaN1J00a3OTNJYNI5UCkgL6iLWF3auHTq5ehn5tXXA84nxR0zAFuQFrhBYr 3fZbkjMWZw4NQhRSZi4tnGy42dlT6E4dOhaoMJggaOYMMmAzADyP52KFZU6Lqqy8 EEVQY36ohqQGPicADcoPaV+EExJjVcHZbkDCbZ3ovhZqQlHXcBnT7wJ3OtNKSsFo W6+5EZFFg+lGZjKtEnWj =Ztnv -----END PGP SIGNATURE----- --67BqmJg2unxe7d8V--