Date: Tue, 1 Mar 2022 14:12:59 -0500
From: Stephen Frost <sfrost@snowman.net>
To: David Steele <david@pgmasters.net>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Chapman Flack <chap@anastigmatix.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <20220301191259.GV10577@tamriel.snowman.net>
References: <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <20220221172306.GA3698472@nathanxps13>
 <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>
 <20220226220614.GA673898@nathanxps13>
 <20220301055100.GA1002387@nathanxps13>
 <e6657efe-f7b1-0894-9807-453c01bad81a@pgmasters.net>
 <621E4529.1090601@anastigmatix.net>
 <20220301173208.GB1031413@nathanxps13>
 <1f685b3a-7ec2-825e-bb2b-d87d78ad5bd9@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Jgs7yVrrV0awjHqX"
Content-Disposition: inline
In-Reply-To: <1f685b3a-7ec2-825e-bb2b-d87d78ad5bd9@pgmasters.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: <https://www.postgresql.org/message-id/20220301191259.GV10577%40tamriel.snowman.net>
Precedence: bulk


--Jgs7yVrrV0awjHqX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* David Steele (david@pgmasters.net) wrote:
> On 3/1/22 11:32, Nathan Bossart wrote:
> >On Tue, Mar 01, 2022 at 11:09:13AM -0500, Chapman Flack wrote:
> >>On 03/01/22 09:44, David Steele wrote:
> >>>Personally, I am in favor of removing it. We change/rename
> >>>functions/tables/views when we need to, and this happens in almost eve=
ry
> >>>release.
> >>
> >>For clarification, is that a suggestion to remove the 'exclusive' param=
eter
> >>in some later release, after using this release to default it to false =
and
> >>reject calls with true?
> >
> >My suggestion was to remove it in v15.  My impression is that David and
> >Stephen agree, but I could be misinterpreting their responses.
>=20
> I agree and I'm pretty sure Stephen does as well.

Yes, +1 to removing it.

> >>That way, at least, there would be a period of time where procedures
> >>that currently work (by passing exclusive =3D> false) would continue to=
 work,
> >>and could be adapted as time permits by removing that argument, with no
> >>behavioral change.
> >
> >I'm not sure if there's any advantage to kicking the can down the road. =
 At
> >some point, we'll need to break existing backup scripts.  Will we be more
> >prepared to do that in v17 than we are now?  We could maintain two sets =
of
> >functions for a few releases and make it really clear in the documentati=
on
> >that pg_start/stop_backup() are going to be removed soon (and always emi=
t a
> >WARNING when they are used).  Would that address your concerns?
>=20
> I think people are going to complain no matter what. If scripts are being
> maintained changing the name is not a big deal (though moving from exclus=
ive
> to non-exclusive may be). If they aren't being maintained then they'll ju=
st
> blow up a few versions down the road when we remove the compatibility
> functions.

I don't consider "maintained" and "still using the exclusive backup
method" to both be able to be true at the same time.

Thanks,

Stephen

--Jgs7yVrrV0awjHqX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJiHnA7AAoJEO1sijiDR2RVm/0P/j8i4hcWeq25J0CPj63LNUEu
iyX7JYsgHGLerkNmjamOiKZASkHQFjXs9BUGlYRrW9z7Fx0WG39/dYis5j6JUYVa
Xpl4ttKGi+SsEqWhO0KUPbY5xNCgCkQuBso362j4ZyDwn1Pn+QsiurFLpaES/s7z
CHLy/AsVJJGcbk1mo9p/2QiVm2zo6+7L2TnmbyOVHg0h13ift+ANA43AmTJpDws5
gqX8vAd11w4UPWqzzJnfvuXeZAmCSqyX1SdhB0iFl5c7yb76NJ43LCIQQXkXE9Z7
y0ugqldeYQsSQy2o+lWa7W0OXl03NJcBwMVDOnpH4KXmIn8wlKFeHVFmOJMH8v9k
yasWzHYcmpCC28lWBL7iBjZkrNKPPgzoipTAOWjptLTcqqpUkFTogvc+LJULpX5c
GqfB+lWJTIkHh4dDaUBZPUy8Mp87gfHtxuCZnsZXcCQyPoHoiMV4wK8TuyBNZZwP
5ACxs3IEwO4xKCuQX8KFC8aDlT4Xl1uflBIQw3N11tfQgHlteYCXb11mXqlRVpRM
GoO4Q8BStzXAonRwGWL8oZoBUVSVyUrvMSE2KfzkoFyCrOR0uWU3WZHjqOOH5V/k
8F3yEfLHrtus1X7TfeqDWUURZ24T4EbEUm423X0TLoBCqZwf/zJoBTJ2BifVjla1
d3MO3/OoNKvaV5FAUYUV
=nS/v
-----END PGP SIGNATURE-----

--Jgs7yVrrV0awjHqX--