Date: Tue, 1 Mar 2022 15:05:23 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Chapman Flack <chap@anastigmatix.net>
Cc: David Steele <david@pgmasters.net>,
	Nathan Bossart <nathandbossart@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <20220301200523.GX10577@tamriel.snowman.net>
References: <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>
 <20220226220614.GA673898@nathanxps13>
 <20220301055100.GA1002387@nathanxps13>
 <e6657efe-f7b1-0894-9807-453c01bad81a@pgmasters.net>
 <621E4529.1090601@anastigmatix.net>
 <20220301173208.GB1031413@nathanxps13>
 <1f685b3a-7ec2-825e-bb2b-d87d78ad5bd9@pgmasters.net>
 <621E6C2E.2050801@anastigmatix.net>
 <20220301191441.GW10577@tamriel.snowman.net>
 <621E7A5C.1030203@anastigmatix.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1X1uH+Y+uHyMJls4"
Content-Disposition: inline
In-Reply-To: <621E7A5C.1030203@anastigmatix.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: <https://www.postgresql.org/message-id/20220301200523.GX10577%40tamriel.snowman.net>
Precedence: bulk


--1X1uH+Y+uHyMJls4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Chapman Flack (chap@anastigmatix.net) wrote:
> On 03/01/22 14:14, Stephen Frost wrote:
> >> There can't really be many teams out there thinking "we'll just ignore
> >> these scripts forever, and nothing bad will happen." They all know the=
y'll
> >> have to do stuff sometimes. But it matters how we allow them to schedu=
le it.
> >=20
> > We only make these changes between major versions.  That's as much as we
> > should be required to provide.
>=20
> It's an OSS project, so I guess we're not required to provide anything.
>=20
> But in the course of this multi-release exclusive to non-exclusive
> transition, we already demonstrated, in 7117685, that we can avoid
> inflicting immediate breakage when there's nothing in our objective
> that inherently requires it, and avoiding it is relatively easy.
>=20
> I can't bring myself to think that was a bad precedent.

It's actively bad because we are ridiculously inconsistent when it comes
to these things and we're terrible about ever removing anything once
it's gotten into the tree as 'deprecated'.  Witness that it's 8 years
since 7117685 and we still have these old and clearly broken APIs
around.  We absolutely need to move *away* from this approach, exactly
how 2dedf4d9, much more recently than 7117685, for all of its other
flaws, did.

> So if I'm outvoted here and the reason is "look, a lighter burden is
> involved this time than that time", then ok. I would rather bow to that
> argument on the specific facts of one case than abandon the precedent
> from 7117685 generally.

It's far from precedent- if anything, it's quite the opposite from how
most changes around here are made, and much more recent commits in the
same area clearly tossed out entirely the idea of trying to maintain
some kind of backwards compatibility with existing scripts.

Thanks,

Stephen

--1X1uH+Y+uHyMJls4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJiHnyDAAoJEO1sijiDR2RVr4MP/3/v+gfkmnKG3AnrfPWWFrnA
GC+Yu5c0/9MsAgQp2nL3lx1D+X8+eU+zJkY5t3xNP3G7DYnLiSaAgmX9D8cTqOGR
Lk1ECLBMRfAEmIV6dOEjRvPuzr+WItrzE9eTJ6vS1svES9BP3xONo8xTH34Zv4r5
FJa74NhP7lqLf5o0Z7t2bgsDgadGL2nWnVO91pGSV5FkmPyqgi9LQBnQ4qT6YpH4
3nD8LbUu9VsWP1AY95oxUolRsJnCPeiciZIsgi+qoYcaSebjsD8vr8Imp46ZraSk
3XaNVJR67VEFTa8gG2KL+8gn8+l8LcXriiLNBUfBOS4N+dz/4PRhzIG94u/AP9wI
7ZH2ydNmF4ZOKjFvjtIOGCJ0jUjOK9TfXuQCMiQXbMMw235J6o7So3nr9oH1qhSp
Lv4lQhfZ1RoUWR78YHf4K7YTarN9tA9Qd+RnpkaDiFdI2ntUgEfooX6kfzzfJWA2
/RB6TGDwYIZXt0t5y9MDcurmnjjzybfopyvM//fj2nukJWCcibyjWC4ChE68NA4a
j5gRb/UEkBLOU0lScfhEC4henyvlqoJENBv1OQnIgIuZY+xGzUfVIvRmEQoJW20J
IZ/souciBayOu1sFzJtnzw7a1ncHpJlsp9MWcBJQLTUR+3w63Ir0aKKCa4wHtGFO
Ctq5WjwtgrXtSnUaZAo/
=FaDi
-----END PGP SIGNATURE-----

--1X1uH+Y+uHyMJls4--