public inbox for [email protected]
help / color / mirror / Atom feedFrom: Julien Rouhaud <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_stop_backup() v2 incorrectly marked as proretset
Date: Thu, 3 Mar 2022 00:36:32 +0800
Message-ID: <20220302163632.6ppfefpw4usen6z5@jrouhaud> (raw)
In-Reply-To: <CAJ7c6TN_MHLv9rH3ijMxVnrL=75JN=yXxXwZ6c7=ETCLk7SWBg@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAJ7c6TO2rq3LTe_TsPgb8RWuAnxd-gs0qV7g6HACu21P9cTXEQ@mail.gmail.com>
<CA+Tgmoas049acSuXnvyZjbsGHDjE+uPnj5eNRLYd_yLxyHBVrw@mail.gmail.com>
<[email protected]>
<CAJ7c6TN_MHLv9rH3ijMxVnrL=75JN=yXxXwZ6c7=ETCLk7SWBg@mail.gmail.com>
On Wed, Mar 02, 2022 at 05:40:00PM +0300, Aleksander Alekseev wrote:
> Hi Tom.
>
> Yeah, there's plenty of precedent for that coding if you look around.
> > I've not read the whole patch, but this snippet seems fine to me
> > if there's also an #undef at the end of the function.
>
> No, there is no #undef. With #undef I don't mind it either.
I don't see strong evidence for that pattern being wildly used with some naive
grepping:
#define for such use without undef:
POSTGRES_FDW_GET_CONNECTIONS_COLS
HEAP_TUPLE_INFOMASK_COLS
CONNECTBY_NCOLS
DBLINK_NOTIFY_COLS
PG_STAT_STATEMENTS_COLS
PG_STAT_STATEMENTS_INFO_COLS
HEAPCHECK_RELATION_COLS
PG_PARTITION_TREE_COLS
PG_STAT_GET_ACTIVITY_COLS
PG_STAT_GET_WAL_COLS
PG_STAT_GET_SLRU_COLS
PG_STAT_GET_REPLICATION_SLOT_COLS
PG_STAT_GET_SUBSCRIPTION_STATS_COLS
PG_GET_BACKEND_MEMORY_CONTEXTS_COLS
PG_GET_SHMEM_SIZES_COLS
PG_GET_REPLICATION_SLOTS_COLS
READ_REPLICATION_SLOT_COLS
PG_STAT_GET_WAL_SENDERS_COLS
PG_STAT_GET_SUBSCRIPTION_COLS
With an undef:
REPLICATION_ORIGIN_PROGRESS_COLS
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_stop_backup() v2 incorrectly marked as proretset
In-Reply-To: <20220302163632.6ppfefpw4usen6z5@jrouhaud>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox