Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPZLZ-0007ZK-NX for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Mar 2022 00:29:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZLY-0002XL-JZ for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Mar 2022 00:29:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPZLY-0002WV-6L for pgsql-hackers@lists.postgresql.org; Thu, 03 Mar 2022 00:29:32 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nPZLQ-0005DC-2E for pgsql-hackers@postgresql.org; Thu, 03 Mar 2022 00:29:31 +0000 Received: by mail-il1-x12e.google.com with SMTP id i1so2781940ila.7 for ; Wed, 02 Mar 2022 16:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=N2WiODATDljb/5UZlqJBeA9FfFozyZZPvHpd/ssNH08=; b=mNOHSiSI9auUBiIT2Cb48A5S4jHAvJbaEt6B6zxrOYeJmbvd29z8Xu8st19hNp5upU ywTk0URAUwVA8YIMbS51xNSQnlwAdCMUqrVLtsWDQ73FEre7PyTWuoeMN9rfPCGnQFyo yawrFNkPfQKdqJXVQVqd4TtUR5Kd5DdLEtGKWak69GYCxMmV9A3Vbj8TpbbZPXPevrxz QIhh+QY69gbYxOW4EaPWd7rTou+KoTxAf4mnr3h28HRZP3K/kqJm/cpa/UQjXlcepyqu oWelrhCy/YYd+h8C/ldbVJHlCxjA6MnlOKJMLqNmZsJQebcrYRuGInl1jjpZgojH5CLo PA+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=N2WiODATDljb/5UZlqJBeA9FfFozyZZPvHpd/ssNH08=; b=2MdUq+ruKNPKPHQ478s3hN0qGWWsYKB9VdtveZWbecHCFB+Hqb73hmezN0/1gZiJ/Q uzuphftmDAhEGSinE2SItbSTSb3xmm5fDjZnsyN9WR3uzTH/ZwwzrTVc4n+2SxBB0lUE pnbWbjXnGEG9YVj9caHjar4p1noHHvJk5ESuPMKlZBL8z9hNvt9eQUhgWSnTCUlFhaWg dYyu5A/Mpj4tlUquCyzCL8UmUsm4gSIJyp4Oar+lR4tYRK8D1VIkO+x41OM+0kObco1P NqZRRqJCZYBksVf3/yJmypZFFJW8iQBNPelePs+pZJGGUPZqN/rJOoxnmMpV3GyOE2bS F/tA== X-Gm-Message-State: AOAM531hobsVQJkWrLsd3ms3d6pqkvOW7CokPBTZvZylD0HmBlw74Ngf qQZ2nijdh5P1ty0UvntsnL9vMw== X-Google-Smtp-Source: ABdhPJzfw3JNfRM6yMAE9huz+cebTP038K+XxJCc5LQprOLbMeepX9oHIofq4jGeTJGpj0q6vD67NA== X-Received: by 2002:a92:6d02:0:b0:2c6:e1:79b with SMTP id i2-20020a926d02000000b002c600e1079bmr441964ilc.67.1646267362559; Wed, 02 Mar 2022 16:29:22 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id b18-20020a92c852000000b002bf7b6b3041sm317668ilq.75.2022.03.02.16.29.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2022 16:29:22 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 3C77D800D8D; Wed, 2 Mar 2022 18:29:21 -0600 (CST) Date: Wed, 2 Mar 2022 18:29:21 -0600 From: Justin Pryzby To: Tomas Vondra Cc: Amit Kapila , Peter Eisentraut , Alvaro Herrera , houzj.fnst@fujitsu.com, Rahila Syed , Peter Smith , pgsql-hackers@postgresql.org Subject: Re: Column Filtering in Logical Replication Message-ID: <20220303002921.GB27651@telsasoft.com> References: <202201120041.p24wvsfcsope@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I applied this patch in my branch with CI hacks to show code coverage on cirrus. https://api.cirrus-ci.com/v1/artifact/task/6186186539532288/coverage/coverage/00-index.html Eyeballing it looks good. But GetActionsInPublication() isn't being hit at all? I think the queries in pg_dump should be written with the common portions of the query outside the conditional. -- Justin