public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: [email protected]
To: Kyotaro Horiguchi <[email protected]>
Subject: Naming of the different stats systems / "stats collector"
Date: Tue, 8 Mar 2022 12:53:51 -0800
Message-ID: <[email protected]> (raw)

Hi,

One thing I'm not yet happy around the shared memory stats patch is
naming. Currently a lot of comments say things like:

  * [...] We convert to
  * microseconds in PgStat_Counter format when transmitting to the collector.

or

# - Query and Index Statistics Collector -

or

/* ----------
 * pgstat_report_subscription_drop() -
 *
 *  Tell the collector about dropping the subscription.
 * ----------
 */


the immediate question for the patch is what to replace "collector" with.

"stats subsystem" is too general, because that could be about
backend_activity.c, or pg_statistic, or ...

"shared memory stats" seems too focussed on the manner of storage, rather than
the kind of stats.

The patch currently uses "activity statistics" in a number of places, but that
is confusing too, because pg_stat_activity is a different kind of stats.

Any ideas?


The postgresql.conf.sample section header seems particularly odd - "index
statistics"? We collect more data about tables etc.


A more general point: Our naming around different types of stats is horribly
confused. We have stats describing the current state (e.g. pg_stat_activity,
pg_stat_replication, pg_stat_progress_*, ...) and accumulated stats
(pg_stat_user_tables, pg_stat_database, etc) in the same namespace.  Should we
try to move towards something more coherent, at least going forward?


Greetings,

Andres Freund

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Naming of the different stats systems / "stats collector"
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox