Date: Thu, 10 Mar 2022 15:00:10 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>,
	Melanie Plageman <melanieplageman@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
Message-ID: <20220310210010.GG28503@telsasoft.com>
References: <20220213220709.vjz5rziuhfdpqxrg@alap3.anarazel.de>
 <20220226025116.GJ9008@telsasoft.com>
 <20220227010908.vz2a7dmfzgwg742w@alap3.anarazel.de>
 <20220227024352.GC25269@telsasoft.com>
 <20220227025000.mjmfimls5gnz7em7@alap3.anarazel.de>
 <20220227031057.GD25269@telsasoft.com>
 <20220227040838.3z4gqihimyerxe3h@alap3.anarazel.de>
 <20220228205802.GE25269@telsasoft.com>
 <20220302205058.GJ15744@telsasoft.com>
 <20220310205015.7k5yr4bhmwutjp6t@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220310205015.7k5yr4bhmwutjp6t@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220310210010.GG28503%40telsasoft.com>
Precedence: bulk

On Thu, Mar 10, 2022 at 12:50:15PM -0800, Andres Freund wrote:
> > -  setup_cores_script: |
> > +  setup_os_script: |
> >      mkdir -m 770 /tmp/cores
> >      chown root:postgres /tmp/cores
> >      sysctl kern.corefile='/tmp/cores/%N.%P.core'
> > +    #pkg install -y ...
> 
> Would you mind if I split this into setup_core_files_script and
> setup_additional_packages_script:?

That's fine.  FYI I'm also planning on using choco install --no-progress
I could resend my latest patches shortly.

> > Subject: [PATCH 6/7] wip: cirrus/windows: add compiler_warnings_script
> > 
> > I'm not sure how to write this test in windows shell; it's also not easy to
> > write it in posix sh, since windows shell is somehow interpretting && and ||...
> 
> That comment isn't accurate anymore now that it's in an external script,
> right?

No, it is accurate.  What I mean is that it's also hard to write it as a
1-liner using posix sh, since the || (and &&) seemed to be interpretted by
cmd.exe and needed escaping - gross.

-- 
Justin