Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSTfr-0007XO-JP for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 01:02:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSTfq-0002XF-3X for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 01:02:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSTfp-0002Ve-Nb for pgsql-hackers@lists.postgresql.org; Fri, 11 Mar 2022 01:02:29 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nSTfm-0007ob-K6 for pgsql-hackers@postgresql.org; Fri, 11 Mar 2022 01:02:29 +0000 Received: by mail-il1-x132.google.com with SMTP id b9so3584120ila.8 for ; Thu, 10 Mar 2022 17:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oj6kGQx2LgL8ftbCxbzsk9Uu/GC8lmsH/R8iU813qSc=; b=u1btAY1wpU/xJur+PfVfuPjLFICFzjI9zKj6wLCb5vyPvGG943tJKvoiJST9YEpZ/H fn9wMgmjuhmJgXC/ng9MDoYgmWF+pRpNvsOiZVrOqyjd7yjmBVCfTu+eB4MOmfBUtpPi eEFqkwEu63KsAA/t4P+hVSxKPMonwfbasFgqGmRJ+giddHPFSzJoZgGB0yp2jCrsxyGx Itzns1xxk9cx/dRXk95rCNF50RUg3v/+v/j+I+Sw808T9G3r4czjTsir/CfJqk3AzGKH Uzz1LxYY57Voww/SF32FubCo7RrHthoT628Pv64SUfuylhkX6IFZRGDOOJHj7bVU5RiN PImw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oj6kGQx2LgL8ftbCxbzsk9Uu/GC8lmsH/R8iU813qSc=; b=4jjFIhdRTlGLdkgZkMER9+ZDzFRaPRgQJxujPDXXYF5lB0W9ldYO/cPOZmI6g3kjJT 9GGKD0Yv9k4zSazx3LWjarsOH+f+rnEnZkhN0nC69hlWBtx3R8rVKlxcX2atHglyEhKX 1Nrmf0qBMxhsPmCLvQ2mdhf3od7KWCbsudS7IJxbd+hBv2Iz+BdiBCtn9f8mGJ4TvsIm Et8gO884kU+XLDqHAC13SM9bMZxVtOUbZwtWukR2wahHSlenrQbuL00vs8RmaLSPZ0Rv SlAhoGPAJrcf+K4D/Tj98O588VHE/YHG77pXpK0bMZJeJh7p0zQwQ9uYGQMwRJ2qjWOj +55w== X-Gm-Message-State: AOAM531b36/xXsZoF/4+z4bJO+4ng7YXKOBfrR+vUqALgG6L6GHQa8XZ 0zIQMRPFgp4bnzpPl8z5QO0sIQ== X-Google-Smtp-Source: ABdhPJyaMKYZMWQw6Ne+Ubg1ruEgodgGj2MCLegEzu/Nvg+zFZTAtWsvOBS1PT9x8JQ4Q4mthPxbtA== X-Received: by 2002:a05:6e02:11a4:b0:2c6:40dc:d30 with SMTP id 4-20020a056e0211a400b002c640dc0d30mr5828724ilj.283.1646960544616; Thu, 10 Mar 2022 17:02:24 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id q9-20020a5edb09000000b00645c7a00cbbsm3302104iop.20.2022.03.10.17.02.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Mar 2022 17:02:24 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 9BD29800DD5; Thu, 10 Mar 2022 19:02:23 -0600 (CST) Date: Thu, 10 Mar 2022 19:02:23 -0600 From: Justin Pryzby To: Jeevan Ladhe Cc: Robert Haas , Alvaro Herrera , "Shinoda, Noriyoshi (PN Japan FSIP)" , Dipesh Pandit , Abhijit Menon-Sen , Dmitry Dolgov <9erthalion6@gmail.com>, Jeevan Ladhe , Mark Dilger , pgsql-hackers@postgresql.org, tushar , Andres Freund Subject: Re: refactoring basebackup.c Message-ID: <20220311010223.GI28503@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I'm getting errors from pg_basebackup when using both -D- and --compress=server-* The issue seems to go away if I use --no-manifest. $ ./src/bin/pg_basebackup/pg_basebackup -h /tmp -Ft -D- --wal-method none --compress=server-gzip >/dev/null ; echo $? pg_basebackup: error: tar member has empty name 1 $ ./src/bin/pg_basebackup/pg_basebackup -h /tmp -Ft -D- --wal-method none --compress=server-gzip >/dev/null ; echo $? NOTICE: WAL archiving is not enabled; you must ensure that all required WAL segments are copied through other means to complete the backup pg_basebackup: error: COPY stream ended before last file was finished 1