Date: Fri, 11 Mar 2022 12:05:11 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Cary Huang <cary.huang@highgo.ca>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: add checkpoint stats of snapshot and mapping files of pg_logical
 dir
Message-ID: <20220311200511.GA682814@nathanxps13>
References: <CALj2ACXwALpiPyqj8n-LLB8J_R_s9pE3xvuGJWjVEBngG6873Q@mail.gmail.com>
 <163823361875.8893.16011115215407536326.pgcf@coridan.postgresql.org>
 <CALj2ACXx9rCRP7RiLKDgh76oUqdsifjeNRGqmgxDmh8K8X85SA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALj2ACXx9rCRP7RiLKDgh76oUqdsifjeNRGqmgxDmh8K8X85SA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220311200511.GA682814%40nathanxps13>
Precedence: bulk

+    CheckpointStats.repl_map_cutoff_lsn = cutoff;

Could we set repl_map_cutoff_lsn closer to where it is calculated?  Right
now, it's set at the bottom of the function just before the directory is
freed.  Is there a strong reason to do it there?

+                        "logical rewrite mapping file(s) removed/synced=" UINT64_FORMAT ", size=%zu bytes, time=%ld.%03d s, cutoff LSN=%X/%X",

Can we split out the "removed" versus "synced" files?  Otherwise, I think
this is basically just telling us how many files are in the mappings
directory.

+    CheckpointStats.repl_snap_cutoff_lsn = cutoff;

I have the same note for this one as I have for repl_map_cutoff_lsn.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com