Date: Sat, 12 Mar 2022 18:56:01 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
Message-ID: <20220313005601.GR28503@telsasoft.com>
References: <20210406160131.GA6592@telsasoft.com>
 <20210702191637.GV21248@telsasoft.com>
 <2AF5FE35-82CB-4259-BF97-30D947803132@amazon.com>
 <20211124000444.GX17618@telsasoft.com>
 <alpine.DEB.2.22.394.2112230912480.2755821@pseudo>
 <20211223173631.GE17618@telsasoft.com>
 <alpine.DEB.2.22.394.2201021306020.2766085@pseudo>
 <20220125192755.GK23027@telsasoft.com>
 <20220309165044.GB27651@telsasoft.com>
 <Yi0+r0651McAo+mR@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yi0+r0651McAo+mR@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220313005601.GR28503%40telsasoft.com>
Precedence: bulk

On Sun, Mar 13, 2022 at 09:45:35AM +0900, Michael Paquier wrote:
> On Wed, Mar 09, 2022 at 10:50:45AM -0600, Justin Pryzby wrote:
> > Rebased over 9e9858389 (Michael may want to look at the tuplestore part?).
> 
> Are you referring to the contents of 0003 here that changes the
> semantics of pg_ls_dir_files() regarding its setup call?

Yes, as it has this:

-       SetSingleFuncCall(fcinfo, SRF_SINGLE_USE_EXPECTED);                                                                                                                                                                       
...
-       SetSingleFuncCall(fcinfo, 0);                                                                                                                                                                                             
...
+       if (flags & LS_DIR_METADATA)                                                                                                                                                                                              
+               SetSingleFuncCall(fcinfo, 0);                                                                                                                                                                                     
+       else                                                                                                                                                                                                                      
+               SetSingleFuncCall(fcinfo, SRF_SINGLE_USE_EXPECTED);                                                                                                                                                               

-- 
Justin