Date: Wed, 16 Mar 2022 09:19:13 +0900 (JST)
Message-Id: <20220316.091913.806120467943749797.horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: bharath.rupireddyforpostgres@gmail.com, masao.fujii@oss.nttdata.com,
 nathandbossart@gmail.com, sfrost@snowman.net, bossartn@amazon.com,
 rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <YjBbwiZSRsGzgbcW@paquier.xyz>
References: <CALj2ACX7XOuOs1dnk93vtez7ULmiPvU0YvAQ7bJnsqQBrUgGRg@mail.gmail.com>
	<20220315.172340.1059971522574284501.horikyota.ntt@gmail.com>
	<YjBbwiZSRsGzgbcW@paquier.xyz>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20220316.091913.806120467943749797.horikyota.ntt%40gmail.com>
Precedence: bulk

At Tue, 15 Mar 2022 18:26:26 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> On Tue, Mar 15, 2022 at 05:23:40PM +0900, Kyotaro Horiguchi wrote:
> > At Tue, 15 Mar 2022 12:19:47 +0530, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote in 
> >> On Fri, Mar 4, 2022 at 10:40 AM Kyotaro Horiguchi
> >> <horikyota.ntt@gmail.com> wrote:
> >> 0001 - I don't think you need to do this as UpdateControlFile
> >> (update_controlfile) will anyway update it, no?
> >> + /* Update control file using current time */
> >> + ControlFile->time = (pg_time_t) time(NULL);
> > 
> > Ugh.. Yes. It is a copy-pasto from older versions.  They may have the
> > same copy-pasto..
> 
> This thread has shifted to an entirely different discussion,
> presenting patches that touch code paths unrelated to what was first
> stated.  Shouldn't you create a new thread with a proper $subject to
> attract a more correct audience?  

I felt the same since some messages ago.  I thought Fujii-san thought
that he wants to fix the CreateRestartPoint issue before the
checkpoint log patch but he looks like busy these days.

Since the CreateRestartPoint issue is orthogonal to the main patch,
I'll separate that part into anther thread.

This thread is discussing one other topic, wordings in user-facing
texts. This is also orthogonal (3-dimentionally?) to the two topics.

In short, I split out the two topics other than checkpoint log to
other threads.

Thanks for cueing me to do that!

regareds.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center