Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUd9s-0002qB-Ok for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Mar 2022 23:34:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUd8s-000211-8r for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Mar 2022 23:33:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUd8r-00020s-UQ for pgsql-hackers@lists.postgresql.org; Wed, 16 Mar 2022 23:33:22 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nUd8m-0002ML-Dx for pgsql-hackers@postgresql.org; Wed, 16 Mar 2022 23:33:20 +0000 Received: by mail-pl1-x62f.google.com with SMTP id n15so3072607plh.2 for ; Wed, 16 Mar 2022 16:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4dQqvpV67SXsR8wf1h+mOoMxGK0g9LaJTcJmTSOnFJc=; b=IEk+tcLEXpLeIcTepBlSK2VaBDUuemBldmmdVDo7RKhdDjCCaamc3o0nNPCLlHYUBn OfhTjnnSI5LqgmmqCqWGgfMRGhXbnKFgQIrr7t0H7n7GGicrNRLMDFvlXQzs+wBfjSKJ /0S7aJE5oiAMUPDF/6OUfXTJo2TANdpK43/lCL4ZPe7S/XvV8ehPLlLpqKN4SdXI3TgK W83blf9/wBL/aw8+Hd3qdbKkVbcX2qNULS1+6HIsVhmiQTnL/LA6b/cJWnScfxqf16+s ieFehu6BFPZFmMTiFsjHwymC6Gosc43+Nc5y+LJjo8wcuK633pXdwbqBOEMPfbgOrzNi yQBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4dQqvpV67SXsR8wf1h+mOoMxGK0g9LaJTcJmTSOnFJc=; b=09U5G725GDqi8HXDNdAW9ehdCKeR+E8DldyWvcGzKO+ByCGkKXFwkfsHR8+XCIHxk5 O69/0zdFrnMT2hV0mwylEteeSPwnjmcE3G+Oy10AWdHQklSDUKjOnVvuDOBHAFakeHH3 2eV3llwfyvHUqwHs586aGrJUUZ7a7YsvqfgMMkMtYsUOv2+mgVqAKMyzrmg0+zbd24mH AiPb/131aPrU5FXDTPtJM1gRqRiY6lrlR5PGpZtZkzXUJdVaOpK2Wo093Z/GzDDe5+FT 3dbQp/gKlvVBav9s4CxCOTAtfKuwDhWgVhRx6S/UFhWMnMfUm5QkbUdj45sv3aJ/gEIU 4X0Q== X-Gm-Message-State: AOAM531ziOFcuBzjpwxmv0s8IffIE1SRDP6Yl6WrY1VZ3TanzWNC14z2 1a/lFVQX+9AE+P/3R9p2feM= X-Google-Smtp-Source: ABdhPJwf9IBwT1D4b0Qa/oQDLYgqCmBtbFRvzYZUPyYT37qQca/zIc5+7shUvPRGDYbU4ndy2JEXFQ== X-Received: by 2002:a17:902:ed82:b0:153:85d5:7dff with SMTP id e2-20020a170902ed8200b0015385d57dffmr1766078plj.79.1647473595369; Wed, 16 Mar 2022 16:33:15 -0700 (PDT) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id q2-20020a638c42000000b003817671cb29sm3336497pgn.41.2022.03.16.16.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 16:33:14 -0700 (PDT) Date: Wed, 16 Mar 2022 16:33:13 -0700 From: Nathan Bossart To: "Imseih (AWS), Sami" Cc: Masahiko Sawada , Peter Geoghegan , "Bossart, Nathan" , Justin Pryzby , "pgsql-hackers@postgresql.org" Subject: Re: Add index scan progress to pg_stat_progress_vacuum Message-ID: <20220316233313.GA1346044@nathanxps13> References: <99A5CBE8-EC10-42AA-ABB4-4C812EEFD294@amazon.com> <20220310005237.GA307769@nathanxps13> <78C9A1C5-8593-47F8-8717-42C554A724E9@amazon.com> <4F14170D-AF67-4FDF-9EB0-2A1F8EA14899@amazon.com> <5E83F41D-8473-414A-B1FB-7E958C9C7C51@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5E83F41D-8473-414A-B1FB-7E958C9C7C51@amazon.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 16, 2022 at 09:47:49PM +0000, Imseih (AWS), Sami wrote: > Spoke to Nathan offline and fixed some more comments/nitpicks in the patch. I don't have any substantial comments for v9, so I think this can be marked as ready-for-committer. However, we probably should first see whether Sawada-san has any comments on the revised approach. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com