Date: Thu, 17 Mar 2022 06:12:20 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Georgios Kokolatos <gkokolatos@pm.me>,
	Magnus Hagander <magnus@hagander.net>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Teach pg_receivewal to use lz4 compression
Message-ID: <20220317111220.GI28503@telsasoft.com>
References: 
 <CA+Tgmob3Y=m982YPpZ2HCGMdLMvEGH3FrJvx3dKogPTcS=WV+A@mail.gmail.com>
 <YYHIgrTDI0dEPzoj@paquier.xyz>
 <98dDHVqTFjZbSkNWXboFJwkOhbR0l6v72vtj31Zels9d5P9wmLxTKqdaipQjkRFEhafwNU3Ds_V0NC8hrpu_JqEJ3JHVIzTIRKNv_IjmVJ4=@pm.me>
 <zHbIxCUEoptJOiCQzyk-_PCLIPSrImAbI1Y98FW2dqeFQSIksCBwvGwYvpLwfQ32_t9cgsg64s-kPGvyC2DfY6UxVfPLW9s0EmPIrxg9mJE=@pm.me>
 <YYOMZAwvggGJDvQ6@paquier.xyz>
 <YYOYIYvudT0uqmiF@paquier.xyz>
 <pm1bMV6zZh9_4tUgCjSVMLxDX4cnBqCDGTmdGlvBLHPNyXbN18x_k00eyjkCCJGEajWgya2tQLUDpvb2iIwlD22IcUIrIt9WnMtssNh-F9k=@pm.me>
 <YYSbOIoH3nBamG+4@paquier.xyz>
 <CA+Tgmob-a2=teyEys6bMj2bR-8zPXARSxv-5ZY4OUhFoer+XGw@mail.gmail.com>
 <YgcGZrBEi3F4oqc7@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgcGZrBEi3F4oqc7@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220317111220.GI28503%40telsasoft.com>
Precedence: bulk

On Sat, Feb 12, 2022 at 12:52:40PM +0900, Michael Paquier wrote:
> On Fri, Feb 11, 2022 at 10:07:49AM -0500, Robert Haas wrote:
> > Over in http://postgr.es/m/CA+TgmoYUDEJga2qV_XbAZ=pGEBaOsgFmzZ6Ac4_sRwOm_+UeHA@mail.gmail.com
> > I was noticing that CreateWalTarMethod doesn't support LZ4
> > compression. It would be nice if it did. I thought maybe the patch on
> > this thread would fix that, but I think maybe it doesn't, because it
> > looks like that's touching the WalDirectoryMethod part of that file,
> > rather than the WalTarMethod part. Is that correct?
> 
> Correct.  pg_receivewal only cares about the directory method, so this
> thread was limited to this part.  Yes, it would be nice to extend
> fully the tar method of walmethods.c to support LZ4, but I was not
> sure what needed to be done, and I am still not sure based on what has
> just been done as of 751b8d23.
> 
> > And, on a related note, Michael, do you plan to get something
> > committed here? 
> 
> Apart from f79962d, babbbb5 and 50e1441, I don't think that there was
> something left to do for this thread.  Perhaps I am missing something?

I think this should use <lz4frame.h>

+#include "lz4frame.h"

commit babbbb595d2322da095a1e6703171b3f1f2815cb
Author: Michael Paquier <michael@paquier.xyz>
Date:   Fri Nov 5 11:33:25 2021 +0900

    Add support for LZ4 compression in pg_receivewal

-- 
Justin