Date: Tue, 22 Mar 2022 16:59:17 -0700
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Message-ID: <20220322235917.5a7exsn5fkbnx6wp@alap3.anarazel.de>
References: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/20220322235917.5a7exsn5fkbnx6wp%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-03-22 01:56:03 +0000, Amit Kapila wrote:
> Add ALTER SUBSCRIPTION ... SKIP.
> 
> This feature allows skipping the transaction on subscriber nodes.
> 
> If incoming change violates any constraint, logical replication stops
> until it's resolved. Currently, users need to either manually resolve the
> conflict by updating a subscriber-side database or by using function
> pg_replication_origin_advance() to skip the conflicting transaction. This
> commit introduces a simpler way to skip the conflicting transactions.
> 
> The user can specify LSN by ALTER SUBSCRIPTION ... SKIP (lsn = XXX),
> which allows the apply worker to skip the transaction finished at
> specified LSN. The apply worker skips all data modification changes within
> the transaction.

This was missing an include of xlogdefs.h in pg_subscription.h, thus failing
in headerscheck. See e.g.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-03-22%2022%3A22%3A05

I've pushed the trivial fix for that. I'll propose adding headerscheck to CI /
cfbot.

Greetings,

Andres Freund