Date: Wed, 23 Mar 2022 18:24:49 +0100
From: "alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [BUG] Panic due to incorrect missingContrecPtr after promotion
Message-ID: <202203231724.jabhgpfqg6dz@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <B41D8D0F-EB06-4C99-BE57-35EB3C8A7C7F@amazon.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202203231724.jabhgpfqg6dz%40alvherre.pgsql>
Precedence: bulk

On 2022-Mar-07, Imseih (AWS), Sami wrote:

> I have gone ahead and backpatched this all the way to 10 as well.

Thanks!  I pushed this now.  I edited the test though: I don't
understand why you went to the trouble of setting stuff in order to call
'pg_ctl promote' (in different ways for older branches), when
$node_standby->promote does the same and is simpler to call.  So I
changed the tests to do that.  (I did verify that without the code fix,
the PANIC indeed is thrown.)

Thank again,

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/