Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXGsd-0000us-TS for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 06:23:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXGsc-0006X0-Qf for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 06:23:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXGsc-0006Wq-9i for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 06:23:30 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nXGsZ-0005KG-RX for pgsql-hackers@postgresql.org; Thu, 24 Mar 2022 06:23:29 +0000 Received: by mail-qk1-x736.google.com with SMTP id g8so2853025qke.2 for ; Wed, 23 Mar 2022 23:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2GVnXmdXnk9wxeLqU+5pNuyUcnQzuOladQM5neH/mMw=; b=YVq19Iwkf0jLMhVHLplzpFak1qsPoAFKvh/zXPToVDwhER/nXEiNVbXUYoWDGJB4Nf syxjX4OqdsmAUVYtOFqnGkFmwQqDx0XS+J0f3BIIK/AGRSFtgWgF22mSrrvKl+FWqFnC erDMz8YI7xFhS4joWEVzbxIBgHQQFHd9rA1vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2GVnXmdXnk9wxeLqU+5pNuyUcnQzuOladQM5neH/mMw=; b=RNY5lTf8T6riB6HE+BPOEIjaJhgYnlKiH5hxE82JnMxpHUX8hWXa1CXuG4wpPJHiZh 2BTGnExREV1OzCXLY4qg3rvcY98RG3mPdaRqXOdWchokGJmoO70FLsuybSBTqk7k4wfy KUj/jMJzK12q2Cle2MiVrFAqL1pn8F7WmIk5QT+w+ANKAUt8e8ZhMC1Awj9HIcUmliNs E+izhEwQ8S6Pl12L8pSGaGCP3uMomnQGa2LtCxEA0sUi/KiHWKAyxRKit4YQErwcwrxW r1Dakllj36PYYKbqtWCdS9ocZ4aIb4Ss8edYr4Wx6uV2k8eSHuTATJ64TCfQL6khRP/l FmnQ== X-Gm-Message-State: AOAM530TsO2M9lHlbvgHXSXn4Am+IBBr/4SbhAlv0H7htqq6Qo/zL7m2 tvs+XhMkXU+POjBAmNxkLZ0eVw== X-Google-Smtp-Source: ABdhPJxg7Zo9TED1hqtgFqLCDWOJEecSzIY0OwCnWP0TaoQBBwdzYdbqKMCr54VfADvwhJQRlaKlhw== X-Received: by 2002:a05:620a:6c4:b0:67d:3912:ea39 with SMTP id 4-20020a05620a06c400b0067d3912ea39mr2330572qky.447.1648103005721; Wed, 23 Mar 2022 23:23:25 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id 1-20020a05620a078100b00648cc800c9dsm1145667qka.103.2022.03.23.23.23.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Mar 2022 23:23:25 -0700 (PDT) Date: Wed, 23 Mar 2022 23:23:23 -0700 From: Noah Misch To: Tom Lane Cc: Andres Freund , pgsql-hackers@postgresql.org Subject: Re: ubsan Message-ID: <20220324062323.GA3240013@rfd.leadboat.com> References: <20220323173537.ll7klrglnp4gn2um@alap3.anarazel.de> <2771659.1648058090@sss.pgh.pa.us> <20220323182137.hgq4qz57yldtbhwl@alap3.anarazel.de> <20220323192241.tzeo6cu6mvepok53@alap3.anarazel.de> <2784183.1648065489@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2784183.1648065489@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 23, 2022 at 03:58:09PM -0400, Tom Lane wrote: > Andres Freund writes: > > I think we should backpatch both, based on the reasoning in > > 46ab07ffda9d6c8e63360ded2d4568aa160a7700 ? > > Yeah, I suppose. Is anyone going to step up and run a buildfarm > member with ubsan enabled? thorntail has been running with UBSan since 2019. I've removed flag -fno-sanitize=nonnull-attribute, which your changes rendered superfluous.