Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXQtY-0000KT-WD for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 17:05:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXQtX-0004UL-TU for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 17:05:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXQtX-0004UB-K4 for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 17:05:07 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXQtR-0007F5-1q for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 17:05:06 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E55465C0176; Thu, 24 Mar 2022 13:04:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 24 Mar 2022 13:04:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=7Mmiw+EoGKxY3WtyQf0tDZOYXvCFSyJwiyqvF84i/SA=; b=QYYqaWFp N0qOwyZu7/dy+fuqG/LB52lJ0C1DyfNaxLt1wyjDmK8oRPjAT+aHZNmB/Z/TTdJQ oKV9EHYwRlgVHGiOj9jpzmSdIewP5Ehv4H6kQ4rjO4LlngROYN1g3rsevOZQGSjK RL688EITV6qlC2ZxRdDnheySwRawcqMnVFmunNgI7hOFrt9XdGRNHbLY4gWeHwYH 3Q2bCMZVVJYJ3037bWrgm1nzCq61vwTMxehH4OchXI7AABzEvtaxGy6D7ocytcvC QNg0+tSeEx6exb3XL4VlPHSfUOxNDkXE3eK8ImKUUhufpmNsCMUa5qr4TK/R7vp7 AlEiiLopWBKCig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegledgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Mar 2022 13:04:58 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id B7F142A08E0; Thu, 24 Mar 2022 14:05:12 -0300 (-03) Date: Thu, 24 Mar 2022 18:05:12 +0100 From: Alvaro Herrera To: Peter Eisentraut Cc: Michael Paquier , Pg Hackers Subject: Re: turn fastgetattr and heap_getattr to inline functions Message-ID: <202203241705.rrrap6cqvpzr@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-24, Peter Eisentraut wrote: > But no compiler is stupid enough not to understand that > > foo() > { > if (something) > return this; > else > return that; > } > > always reaches a return. We have a number of examples of this pattern, so I guess it must be true. Pushed without the pg_unreachables, then. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Las navajas y los monos deben estar siempre distantes" (Germán Poo)