Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXj0x-00086P-Kw for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 12:25:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXj0w-0005LG-9h for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 12:25:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXj0v-0005L1-52 for pgsql-hackers@lists.postgresql.org; Fri, 25 Mar 2022 12:25:58 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXj0r-0002Ep-Jx for pgsql-hackers@postgresql.org; Fri, 25 Mar 2022 12:25:56 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D32605C00DF; Fri, 25 Mar 2022 08:25:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 25 Mar 2022 08:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=Z/ade9Lk6iZou/7R02cSHR6nyv1Cgdmjx4ybr/M8x8M=; b=M9kmUZB6 BRqqrk/Si8tIZU7+23qx2wbyzWRok48+4/Oq3hxvheBVUG+yCuqjEWwuBtKMFNss kVyfAbXAMRI6qdIF9m9Nw9TTWPDAhGvyLjcG/yxhOGHWaFS6RfLhomCPsdFfGjQg WWZ0mQRGLUfjmaMKhCr5okILvIUts2POcDXbyn0SXJJCA6xM9COdsGQxBq1kes+q jXeuBpJOULjGCrZTia7Tx8fEM2TRCdh5LbIZzj/ico2grYGFdlyLb+aBKEOfak/c ftuoV8C6HZy5QqLh+NKMPz67iAZgxqamW6KZOTCRMAO6xcF2032Dn3eOvQjra/oq Lt8SzT3COsQQPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehuddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugfgjgesthekre dttddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgv segrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepudejveejffejve duudetvdekieeuiedtvdeileefkeevjedufeeguedvjefhueelnecuffhomhgrihhnpegv nhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Mar 2022 08:25:50 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 710B42A08E2; Fri, 25 Mar 2022 09:26:05 -0300 (-03) Date: Fri, 25 Mar 2022 13:26:05 +0100 From: Alvaro Herrera To: Kyotaro Horiguchi Cc: michael@paquier.xyz, rjuju123@gmail.com, pgsql-hackers@postgresql.org Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion) Message-ID: <202203251226.gtrffvumu2qg@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202203211843.ufy24c7nzkjr@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-21, Alvaro Herrera wrote: > I had a look at this latest version of the patch, and found some things > to tweak. Attached is v21 with three main changes from Kyotaro's v20: Pushed this, backpatching to 14 and 13. It would have been good to backpatch further, but there's an (textually trivial) merge conflict related to commit e6d8069522c8. Because that commit conceptually touches the same area that this bugfix is about, I'm not sure that backpatching further without a lot more thought is wise -- particularly so when there's no way to automate the test in branches older than master. This is quite annoying, considering that the bug was reported shortly before 12 went into beta. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "If you have nothing to say, maybe you need just the right tool to help you not say it." (New York Times, about Microsoft PowerPoint)