Date: Mon, 28 Mar 2022 21:13:52 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Fabien COELHO <coelho@cri.ensmp.fr>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
Message-ID: <20220329021352.GW28503@telsasoft.com>
References: <2AF5FE35-82CB-4259-BF97-30D947803132@amazon.com>
 <20211124000444.GX17618@telsasoft.com>
 <alpine.DEB.2.22.394.2112230912480.2755821@pseudo>
 <20211223173631.GE17618@telsasoft.com>
 <alpine.DEB.2.22.394.2201021306020.2766085@pseudo>
 <20220125192755.GK23027@telsasoft.com>
 <20220309165044.GB27651@telsasoft.com>
 <20220322012828.nugorvsuiutydjkv@alap3.anarazel.de>
 <Yjq7f5VHRPtwvs6E@paquier.xyz>
 <Yj73yraY43IhgwiK@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yj73yraY43IhgwiK@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220329021352.GW28503%40telsasoft.com>
Precedence: bulk

On Sat, Mar 26, 2022 at 08:23:54PM +0900, Michael Paquier wrote:
> On Wed, Mar 23, 2022 at 03:17:35PM +0900, Michael Paquier wrote:
> > FWIW, per my review the bit of the patch set that I found the most
> > relevant is the addition of a note in the docs of pg_stat_file() about
> > the case where "filename" is a link, because the code internally uses
> > stat().   The function name makes that obvious, but that's not
> > commonly known, I guess.  Please see the attached, that I would be
> > fine to apply.
> 
> Hmm.  I am having second thoughts on this one, as on Windows we rely
> on GetFileInformationByHandle() for the emulation of stat() in
> win32stat.c, and it looks like this returns some information about the
> junction point and not the directory or file this is pointing to, it
> seems.

Where did you find that ?  What metadata does it return about the junction
point ?  We only care about a handful of fields.