Date: Thu, 31 Mar 2022 09:37:15 -0700
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Removing more vacuumlazy.c special cases, relfrozenxid
 optimizations
Message-ID: <20220331163715.6tsbbk6axjakglow@alap3.anarazel.de>
References: 
 <CAH2-WzmwM81qMxjYdm4-Z51PKwsgXXAr21bfBRncXCR7VB8W1g@mail.gmail.com>
 <CAH2-Wzn_LLtTk-jGranhLcciSt_70pFKJNngZOf8Gt_MNgTmnA@mail.gmail.com>
 <20220331020018.qht46hbua4gztmdf@alap3.anarazel.de>
 <CAH2-WzmRZEzeGvLv8yDW0AbFmSvJjTziORqjVUrf74mL4GL0Ww@mail.gmail.com>
 <20220331032844.j7wu5ijjpx3qay5c@alap3.anarazel.de>
 <CAH2-WzkvYTo4rbUi_izHOvcHNw78Ur9xLPGvj1PmDgt-csc8QQ@mail.gmail.com>
 <20220331040407.ole7orep6sj4iore@alap3.anarazel.de>
 <20220331042038.udnydrj4x45i4khb@alap3.anarazel.de>
 <CAH2-WzmN4qh04TcyNph8=1awdUN-nzza_6y+TRbEo-ECiCDV0w@mail.gmail.com>
 <20220331045915.srhbzkajlmptclhz@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331045915.srhbzkajlmptclhz@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20220331163715.6tsbbk6axjakglow%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-03-30 21:59:15 -0700, Andres Freund wrote:
> On 2022-03-30 21:29:16 -0700, Peter Geoghegan wrote:
> > On Wed, Mar 30, 2022 at 9:20 PM Andres Freund <andres@anarazel.de> wrote:
> > > Perhaps we should just fetch the horizons from the "local" catalog for shared
> > > rels?
> > 
> > Not sure what you mean.
> 
> Basically, instead of relying on the relcache, which for shared relation is
> vulnerable to seeing "too new" horizons due to the shared relcache init file,
> explicitly load relfrozenxid / relminmxid from the the catalog / syscache.
> 
> I.e. fetch the relevant pg_class row in heap_vacuum_rel() (using
> SearchSysCache[Copy1](RELID)). And use that to set vacrel->relfrozenxid
> etc. Whereas right now we only fetch the pg_class row in
> vac_update_relstats(), but use the relcache before.

Perhaps we should explicitly mask out parts of relcache entries in the shared
init file that we know to be unreliable. I.e. set relfrozenxid, relminmxid to
Invalid* or such.

I even wonder if we should just generally move those out of the fields we have
in the relcache, not just for shared rels loaded from the init
fork. Presumably by just moving them into the CATALOG_VARLEN ifdef.

The only place that appears to access rd_rel->relfrozenxid outside of DDL is
heap_abort_speculative().

Greetings,

Andres Freund