public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Date: Fri, 01 Apr 2022 13:21:57 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoY1rUjA+RaRug791YAtNgNeNxXtEC8ytig6LNHa9_FTug@mail.gmail.com>
References: <CA+TgmobV+twyiCw38KiqVyJDNXEJ=GZgC18bMxGvgHZNhYEXKA@mail.gmail.com>
	<[email protected]>
	<CA+TgmoY1rUjA+RaRug791YAtNgNeNxXtEC8ytig6LNHa9_FTug@mail.gmail.com>

At Tue, 29 Mar 2022 09:31:42 -0400, Robert Haas <[email protected]> wrote in 
> On Tue, Mar 29, 2022 at 9:28 AM Alvaro Herrera <[email protected]> wrote:
> > OK, this is a bug that's been open for years.   A fix can be committed
> > after the feature freeze anyway.
> 
> +1

By the way, may I ask how do we fix this?  The existing recovery code
already generates just-to-be-delete files in a real directory in
pg_tblspc sometimes, and elsewise skip applying WAL records on
nonexistent heap pages.  It is the "mixed" way.

1. stop XLogReadBufferForRedo creating a file in nonexistent
  directories then remember the failure (I'm not sure how big the
  impact is.)


2. unconditionally create all objects required for recovery to proceed..
  2.1 and igore the failures.
  2.2 and remember the failures.

3. Any other?

2 needs to create a real directory in pg_tblspc. So 1?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox