Date: Fri, 01 Apr 2022 17:28:52 +0900 (JST)
Message-Id: <20220401.172852.1154281926306406898.horikyota.ntt@gmail.com>
To: er@xs4all.nl
Cc: boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()",
 File: "toast_internals.c", Line: 670, PID: 19403)
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20220330.175824.936439875658680065.horikyota.ntt@gmail.com>
References: <20220330.100617.1491348930290941094.horikyota.ntt@gmail.com>
	<20220330.114613.1177577626285014184.horikyota.ntt@gmail.com>
	<20220330.175824.936439875658680065.horikyota.ntt@gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20220401.172852.1154281926306406898.horikyota.ntt%40gmail.com>
Precedence: bulk

At Wed, 30 Mar 2022 17:58:24 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Wed, 30 Mar 2022 11:46:13 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > But, in the first place the *fix* has been found to be wrong.  I'm
> > going to search for the right fix..
> 
> FETCH uses the snapshot at DECLARE. So anyhow I needed to set the
> queryDesk's snapshot used in PortalRunSelect to the FETCH's portal's
> holdSnapshot.  What I did in this version is:

By the way, this is, given that the added check in init_toast_snapshot
is valid, a long-standing "bug", which at least back to 12.

I'm not sure what to do for this.

1. ignore the check for certain cases?

2. apply any fix only to master and call it a day.  14 and earlier
  doesn't have the assertion check so they don't complain.

3. apply a fix to all affected versions.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center