Date: Fri, 1 Apr 2022 00:44:23 -0700
From: Noah Misch <noah@leadboat.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	"osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
	vignesh C <vignesh21@gmail.com>,
	Greg Nancarrow <gregn4422@gmail.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Alexey Lesovsky <lesovsky@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Skipping logical replication transactions on subscriber side
Message-ID: <20220401074423.GC3682158@rfd.leadboat.com>
References: 
 <CAA4eK1LK6tOuqON3HtVGU7THyX82awJA16CO_gKyrQ80haQ6ng@mail.gmail.com>
 <CAD21AoCwYVdiDMGkmm6Rg5=VTDyB=zWFYHkJ2fjT6DaD+hOe7w@mail.gmail.com>
 <CAA4eK1KwKVV-+ooiHH19=4YyfHyWfXS617+T-ePL=N4pfep_OA@mail.gmail.com>
 <CAA4eK1JO-B67Qf_ftj_YOCvwbsW=3mk+tXivXHfbxZZBDA-cjg@mail.gmail.com>
 <CAD21AoDL8HGh7AExZsXvkJzrBN9zgk78sJoQiurnvf88xtM5XA@mail.gmail.com>
 <CAA4eK1KCMdKUMGCMi_qk5-SmSKSe1jGzRyYMh0pfmEdx_B47YA@mail.gmail.com>
 <c092b93b-5017-4b31-b8f0-53b0ba7995be@www.fastmail.com>
 <CAA4eK1JbLRj6pSUENfDFsqj0+adNob_=RPXpnUnWFBskVi5JhA@mail.gmail.com>
 <6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com>
 <CAA4eK1+bps=a5n-KzKd58qB-jPcEhy9vc+vDfhZFfGBtA2PPmg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1+bps=a5n-KzKd58qB-jPcEhy9vc+vDfhZFfGBtA2PPmg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20220401074423.GC3682158%40rfd.leadboat.com>
Precedence: bulk

On Tue, Mar 29, 2022 at 10:43:00AM +0530, Amit Kapila wrote:
> On Mon, Mar 21, 2022 at 5:51 PM Euler Taveira <euler@eulerto.com> wrote:
> > On Mon, Mar 21, 2022, at 12:25 AM, Amit Kapila wrote:
> > I have fixed all the above comments as per your suggestion in the
> > attached. Do let me know if something is missed?
> >
> > Looks good to me.
> 
> This patch is committed
> (https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=208c5d65bbd60e33e272964578cb74182ac726a8).

src/test/subscription/t/029_on_error.pl has been failing reliably on the five
AIX buildfarm members:

# poll_query_until timed out executing this query:
# SELECT subskiplsn = '0/0' FROM pg_subscription WHERE subname = 'sub'
# expecting this output:
# t
# last actual query output:
# f
# with stderr:
timed out waiting for match: (?^:LOG:  done skipping logical replication transaction finished at 0/1D30788) at t/029_on_error.pl line 50.

I've posted five sets of logs (2.7 MiB compressed) here:
https://drive.google.com/file/d/16NkyNIV07o0o8WM7GwcaAYFQDPTkULkR/view?usp=sharing


The members have not actually uploaded these failures, due to an OOM in the
Perl process driving the buildfarm script.  I think the OOM is due to a need
for excess RAM to capture 029_on_error_subscriber.log, which is 27MB here.  I
will move the members to 64-bit Perl.  (AIX 32-bit binaries OOM easily:
https://www.postgresql.org/docs/devel/installation-platform-notes.html#INSTALLATION-NOTES-AIX.)