Date: Sun, 3 Apr 2022 13:54:14 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>, tgl@sss.pgh.pa.us,
	nagata@sraoss.co.jp, thomas.munro@gmail.com,
	m.polyakova@postgrespro.ru, pgsql-hackers@postgresql.org,
	teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Message-ID: <202204031154.qrl4cvuumzcl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.22.394.2204030956500.2117840@pseudo>
Archived-At: 
 <https://www.postgresql.org/message-id/202204031154.qrl4cvuumzcl%40alvherre.pgsql>
Precedence: bulk

On 2022-Apr-03, Fabien COELHO wrote:

> > What about this? (a log line is not actually folded)
> > interval_start num_transactions sum_latency sum_latency_2 min_latency max_latency
> > failures serialization_failures deadlock_failures retried retries [ sum_lag sum_lag_2 min_lag max_lag [ skipped ] ]
> 
> My 0.02€:
> 
> I agree that it would be better to have a more deterministic aggregated log
> format.
> 
> ISTM that it should skip failures and lags if no fancy options has been
> selected, i.e.:
> 
>   [ fails ... retries [ sum_lag ... [ skipped ] ] ?

I think it's easier to just say "if feature X is not enabled, then
columns XYZ are always zeroes".

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/