Date: Tue, 5 Apr 2022 13:06:17 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: David Steele <david@pgmasters.net>,
	Chapman Flack <chap@anastigmatix.net>,
	Magnus Hagander <magnus@hagander.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <20220405200617.GA1141296@nathanxps13>
References: <20220310000622.GA225595@nathanxps13>
 <622A941A.90909@anastigmatix.net>
 <20220311003834.GA597706@nathanxps13>
 <20220328203027.GK10577@tamriel.snowman.net>
 <20220329020948.GA311150@nathanxps13>
 <17837e22-9b8d-f8d7-bc8b-7d3eaee3186b@pgmasters.net>
 <20220404142247.GA663209@nathanxps13>
 <20220404154218.GA792581@nathanxps13>
 <4c4ae416-be44-754e-7ee0-7083c11e7cfb@pgmasters.net>
 <20220405152536.GT10577@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405152536.GT10577@tamriel.snowman.net>
Archived-At: 
 <https://www.postgresql.org/message-id/20220405200617.GA1141296%40nathanxps13>
Precedence: bulk

On Tue, Apr 05, 2022 at 11:25:36AM -0400, Stephen Frost wrote:
> Please find attached an updated patch + commit message.  Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review.  This is looking pretty good to me, but other thoughts are
> certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.

LGTM!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com