Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWtE-0000ev-Nh for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 18:29:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncWtD-00009n-Jm for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 18:29:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWtD-0008Vf-A7 for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 18:29:51 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWtB-0001Lm-1N for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 18:29:50 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BBF313201FC6; Thu, 7 Apr 2022 14:29:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 07 Apr 2022 14:29:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=d/Z7csgGzir9L4z5vwh+aVFZwVWuAD81yQLtQm5Cjzk=; b=TAWFvJ2M Krh9GkY0E3WiGKDjg41qhqUel5CkaMgXCVPlHze4Uv0f/rZ7wNfRvOQGBa5wmnfn wyohkfUOL0QTh/SOW7DuIvMj9KeKvfwT4N8pRHc1sxRH3Ti8L+GAY9h637ADsrqG mV8YI2EGA3UEAJ2pwPUgeVCV7Snwe5/jXVIU7VnJvWKXcX79JDT5bnnmqDH7ndDW U2muI+JfDI7i8JkYAn0nYTiIf2Zeyn/nKihbc/J7TZ1OI1geZW1Q0Lgepar742ij A5aJsWPyCs3YGKSZkMjK/CXqSAuahR16quKxbp7TbEmbx3GA2bhZiUMdKj1GRr0b Ypoq2hN5mhtEcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejkedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepudejveejffejveduudetvdekieeuiedtvdeileefkeev jedufeeguedvjefhueelnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 14:29:47 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id B07912A0677; Thu, 7 Apr 2022 14:29:44 -0400 (-04) Date: Thu, 7 Apr 2022 20:29:44 +0200 From: Alvaro Herrera To: Tom Lane Cc: Andres Freund , pgsql-hackers@lists.postgresql.org, Jaime Casanova Subject: Re: LogwrtResult contended spinlock Message-ID: <202204071829.cah732wiswdb@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202204051816.c2u5wz6ru3ni@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Apr-05, Alvaro Herrera wrote: > Apologies -- I selected the wrong commit to extract the commit message > from. Here it is again. I also removed an obsolete /* XXX */ comment. I spent a lot of time staring at this to understand the needs for memory barriers in the interactions. In the end I decided not to get this out for this cycle because I don't want to create subtle bugs in WAL. I'll come back with this for pg16. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "El que vive para el futuro es un iluso, y el que vive para el pasado, un imbécil" (Luis Adler, "Los tripulantes de la noche")