Date: Thu, 14 Apr 2022 08:41:13 -0700
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Erik Rijkers <er@xs4all.nl>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File:
 "toast_internals.c", Line: 670, PID: 19403)
Message-ID: <20220414154113.37f5khnjcc6odtgz@alap3.anarazel.de>
References: <dbebe820-eec3-d643-aab7-26a33392c27b@xs4all.nl>
 <20220330.100617.1491348930290941094.horikyota.ntt@gmail.com>
 <20220330.114613.1177577626285014184.horikyota.ntt@gmail.com>
 <20220330.175824.936439875658680065.horikyota.ntt@gmail.com>
 <20220413202819.GR26620@telsasoft.com>
 <20220414003802.e37dgzkgbi5t7ha4@alap3.anarazel.de>
 <CA+TgmoZ1P5XxBvk1sU9s5hpHXAZf8u5oHTP1+h_otx2kHaG9QQ@mail.gmail.com>
 <1471620.1649947373@sss.pgh.pa.us>
 <CA+TgmoagKyvcMip+thF8JS0Jc9kAnQnZS0xBpTetixRukdh=qg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+TgmoagKyvcMip+thF8JS0Jc9kAnQnZS0xBpTetixRukdh=qg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220414154113.37f5khnjcc6odtgz%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-04-14 11:33:45 -0400, Robert Haas wrote:
> On Thu, Apr 14, 2022 at 10:42 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> > > On Wed, Apr 13, 2022 at 8:38 PM Andres Freund <andres@anarazel.de> wrote:
> > >> FWIW, that'd just mean it's an old bug that wasn't easily noticeable
> > >> before, not that it's the fault of 277692220.
> >
> > > I think you're still on the hook to do something about it for this
> > > release.
> >
> > I think you're trying to shoot the messenger.  As Andres says,
> > 277692220 just exposes that there is some pre-existing bug here.
> > It's probably related to 84f5c2908, so I was planning to take a
> > look at it at some point, but there are a few other higher-priority
> > bugs in the way.
> 
> Well, if you're willing to look at it that's fine, but I just don't
> agree that it's OK to just commit things that add failing assertions
> and drive off into the sunset.

I'm not planning to ride into the sunset / ignore this issue. All I said
is that it's imo not the right thing to say that that commit broke
things in 15. And that not a semantics game, because it means that the
fix needs to go back further than 277692220.

Greetings,

Andres Freund