Date: Sun, 17 Apr 2022 06:31:12 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Erik Rijkers <er@xs4all.nl>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File:
 "toast_internals.c", Line: 670, PID: 19403)
Message-ID: <20220417133112.phzg25rs66w5zipv@alap3.anarazel.de>
References: <CA+TgmoaLb0j9zEfkk6bmuKM5422JenzzcJLJSiPLgwfMd+xnBw@mail.gmail.com>
 <20220414165425.pxn22hdlwdrcouh6@alap3.anarazel.de>
 <CA+TgmoYKWXhYRRSHwMTo-N48i64jOvq1yYmwrz7vHKFGnOyy8Q@mail.gmail.com>
 <1527714.1649957811@sss.pgh.pa.us>
 <CA+Tgmob93_YftfhrSF+OpNWXWtv2bq774yBH3JxPiJf=-DxoiA@mail.gmail.com>
 <1535399.1649963150@sss.pgh.pa.us>
 <CA+Tgmoap=U6yeftFb4-EbMQ1xAXE8ZZ+_GRAkTwx4L+jr+zNoA@mail.gmail.com>
 <1542208.1649967960@sss.pgh.pa.us>
 <CA+TgmoY5A+JoVZODuLaLiu6s=sNKPdOv-Mf2K43yKfg6Cp5MDw@mail.gm! ail.com>
 <1971135.1650134559@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1971135.1650134559@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20220417133112.phzg25rs66w5zipv%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-04-16 14:42:39 -0400, Tom Lane wrote:
> In the meantime, since it's clear that HaveRegisteredOrActiveSnapshot
> is failing to meet its contract, I'm going to go fix it.

+1


> I think (based on the above argument) that what it intends to enforce
> is not really the system design we need, but it certainly isn't
> helping anyone that it enforces that design incorrectly.

I think it's approximately right for the current caller. But that caller
likely needs an improved design around snapshots...

Greetings,

Andres Freund