Date: Wed, 20 Apr 2022 14:04:03 -0700
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson -v8
Message-ID: <20220420210403.zlyi42hx5thvwce3@alap3.anarazel.de>
References: <20220308025629.3xh2yo4sau74oafo@alap3.anarazel.de>
 <721828a7-3043-6803-a85b-da63538db3cc@enterprisedb.com>
 <20220309164420.rr5lws22asrd5mfm@alap3.anarazel.de>
 <20220322022208.44py5lk7twdfuqb5@alap3.anarazel.de>
 <78b4383b-1e25-aacd-7c41-ecdeb8a3292f@enterprisedb.com>
 <20220328195913.rz3bllzhr26innoi@alap3.anarazel.de>
 <498f4933-7fa9-6815-7574-1d3b2ec85daf@dunslane.net>
 <1037188.1648508299@sss.pgh.pa.us>
 <20220328231140.7ylalxc76zli6p46@alap3.anarazel.de>
 <ada92faf-77b5-30b9-669b-ba0899ef7b42@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ada92faf-77b5-30b9-669b-ba0899ef7b42@enterprisedb.com>
Archived-At: <https://www.postgresql.org/message-id/20220420210403.zlyi42hx5thvwce3%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-04-13 12:26:05 +0200, Peter Eisentraut wrote:
> Some feedback and patches for your branch at
> 3274198960c139328fef3c725cee1468bbfff469:

Thanks! I just rebased the branch, will merge your changes once the fallout
from that is fixed...


> 0001-Install-a-few-more-files.patch
> 
> These are just some files that were apparently forgotten to be installed so
> far.

> 0002-Adjust-some-header-file-installation-paths.patch
> 
> The installation of server headers is apparently still in progress. This
> just adjusts the installation directory of those that are already being
> dealt with, so they match the existing installation layout.


Yea. I've not at all paid attention to that so far, besides getting tests to
pass.


> 0003-Fix-warnings-about-deprecated-features.patch
> 
> This fixes some deprecation warnings and raises the requirement to 0.56.

I don't see any deprecation warnings - I see some notices about *future*
deprecated features being used:

NOTICE: Future-deprecated features used:
 * 0.55.0: {'ExternalProgram.path'}
 * 0.56.0: {'meson.source_root', 'meson.build_root'}

(i.e. once the minimum version is increased to > 0.54, those will trigger
deprecation warnings)

What are you seeing with what version?


> I'm not sure why the current cutoff at 0.54 was chosen.  Perhaps that could
> be documented.

Not quite sure why I ended up with 0.54. We definitely should require at most
0.56, as that's the last version supporting python 3.5.


> 0004-Install-postmaster-symlink.patch
> 
> This needs 0.61, so maybe it's a bit too new.

Yea, that's too new. I think we can just create the symlink using ln or such
if we need it.


> Or we could get rid of the postmaster symlink altogether?

But that seems like a better approach.


> 0005-Workaround-for-Perl-detection.patch
> 
> This is needed on my system to get the Perl detection to pass.  If I look at
> the equivalent configure code, some more refinement appears to be needed in
> this area.

> From 1f80e1ebb8efeb0eba7d57032282520fd6455b0d Mon Sep 17 00:00:00 2001
> From: Peter Eisentraut <peter@eisentraut.org>
> Date: Wed, 13 Apr 2022 11:50:52 +0200
> Subject: [PATCH 5/5] Workaround for Perl detection
> 
> ---
>  meson.build | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 1bf53ea24d..e33ed11b08 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -545,9 +545,9 @@ else
>    # file existence.
>    if perl_may_work
>      perl_ccflags += ['-I@0@'.format(perl_inc_dir)]
> -    if host_machine.system() == 'darwin'
> -      perl_ccflags += ['-iwithsysroot', perl_inc_dir]
> -    endif
> +    #if host_machine.system() == 'darwin'
> +    #  perl_ccflags += ['-iwithsysroot', perl_inc_dir]
> +    #endif
>    endif

What problem do you see without this? It did build on CI and on my m1 mini box
as is...

Greetings,

Andres Freund