public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v6 05/10] doc: s/evade/avoid/
7+ messages / 5 participants
[nested] [flat]
* [PATCH v6 05/10] doc: s/evade/avoid/
@ 2020-04-06 22:16 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Justin Pryzby @ 2020-04-06 22:16 UTC (permalink / raw)
---
src/backend/access/gin/README | 2 +-
src/backend/utils/adt/jsonpath_exec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/access/gin/README b/src/backend/access/gin/README
index 125a82219b..41d4e1e8a0 100644
--- a/src/backend/access/gin/README
+++ b/src/backend/access/gin/README
@@ -413,7 +413,7 @@ leftmost leaf of the tree.
Deletion algorithm keeps exclusive locks on left siblings of pages comprising
currently investigated path. Thus, if current page is to be removed, all
required pages to remove both downlink and rightlink are already locked. That
-evades potential right to left page locking order, which could deadlock with
+avoids potential right to left page locking order, which could deadlock with
concurrent stepping right.
A search concurrent to page deletion might already have read a pointer to the
diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c
index f146767bfc..2d2eb7d7a3 100644
--- a/src/backend/utils/adt/jsonpath_exec.c
+++ b/src/backend/utils/adt/jsonpath_exec.c
@@ -35,7 +35,7 @@
* executeItemOptUnwrapTarget() function have 'unwrap' argument, which indicates
* whether unwrapping of array is needed. When unwrap == true, each of array
* members is passed to executeItemOptUnwrapTarget() again but with unwrap == false
- * in order to evade subsequent array unwrapping.
+ * in order to avoid subsequent array unwrapping.
*
* All boolean expressions (predicates) are evaluated by executeBoolItem()
* function, which returns tri-state JsonPathBool. When error is occurred
--
2.17.0
--C+ts3FVlLX8+P6JN
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="v6-0006-doc-Add-logical-replication-support-to-replicate-.patch"
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
@ 2022-04-20 21:32 Alvaro Herrera <[email protected]>
2022-04-20 21:38 ` Re: typos Justin Pryzby <[email protected]>
2022-04-21 04:36 ` Re: typos Michael Paquier <[email protected]>
0 siblings, 2 replies; 7+ messages in thread
From: Alvaro Herrera @ 2022-04-20 21:32 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: David Rowley <[email protected]>; pgsql-hackers; Fabien COELHO <[email protected]>; Amit Kapila <[email protected]>
On 2022-Apr-19, Alvaro Herrera wrote:
> I propose we standardize on <productname>Zstd</productname> everywhere.
> Users can look it up if they're really interested.
So the attached.
There are other uses of <literal>zstd</literal>, but those are referring to the
executable program.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No necesitamos banderas
No reconocemos fronteras" (Jorge González)
Attachments:
[text/x-diff] 0001-Zstd.patch (2.3K, ../../[email protected]/2-0001-Zstd.patch)
download | inline diff:
From 256904cc5a8718ac081dbf51f6263ab022e503f6 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <[email protected]>
Date: Wed, 20 Apr 2022 23:26:28 +0200
Subject: [PATCH] Zstd
---
doc/src/sgml/install-windows.sgml | 6 +++---
doc/src/sgml/installation.sgml | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index 43cc5f6f5b..104670d295 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m";
</varlistentry>
<varlistentry>
- <term><productname>ZSTD</productname></term>
+ <term><productname>Zstd</productname></term>
<listitem><para>
- Required for supporting <productname>ZSTD</productname> compression
+ Required for supporting <productname>Zstd</productname> compression
method. Binaries and source can be downloaded from
<ulink url="https://github.com/facebook/zstd/releases"></ulink>.
</para></listitem>
@@ -560,7 +560,7 @@ $ENV{PROVE_TESTS}='t/020*.pl t/010*.pl'
<varlistentry>
<term><varname>ZSTD</varname></term>
<listitem><para>
- Path to a <application>zstd</application> command. The default is
+ Path to a <application>Zstd</application> command. The default is
<literal>zstd</literal>, which will search for a command by that
name in the configured <envar>PATH</envar>.
</para></listitem>
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index df32025a86..c60484e221 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -273,7 +273,7 @@ su - postgres
<listitem>
<para>
- You need <productname>zstd</productname>, if you want to support
+ You need <productname>Zstd</productname>, if you want to support
compression of data with that method; see
<xref linkend="guc-wal-compression"/>.
The minimum required version is 1.4.0.
@@ -996,7 +996,7 @@ build-postgresql:
<term><option>--with-zstd</option></term>
<listitem>
<para>
- Build with <productname>ZSTD</productname> compression support.
+ Build with <productname>Zstd</productname> compression support.
</para>
</listitem>
</varlistentry>
--
2.30.2
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
@ 2022-04-20 21:38 ` Justin Pryzby <[email protected]>
2022-05-11 02:03 ` Re: typos Justin Pryzby <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Justin Pryzby @ 2022-04-20 21:38 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: David Rowley <[email protected]>; pgsql-hackers; Fabien COELHO <[email protected]>; Amit Kapila <[email protected]>
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-19, Alvaro Herrera wrote:
>
> > I propose we standardize on <productname>Zstd</productname> everywhere.
> > Users can look it up if they're really interested.
>
> So the attached.
>
> There are other uses of <literal>zstd</literal>, but those are referring to the
> executable program.
This one shouldn't be changed, or not like this?
> @@ -560,7 +560,7 @@ $ENV{PROVE_TESTS}='t/020*.pl t/010*.pl'
> <varlistentry>
> <term><varname>ZSTD</varname></term>
> <listitem><para>
> - Path to a <application>zstd</application> command. The default is
> + Path to a <application>Zstd</application> command. The default is
> <literal>zstd</literal>, which will search for a command by that
> name in the configured <envar>PATH</envar>.
> </para></listitem>
Maybe it should say s/a/the/, like:
- Path to a <application>zstd</application> command. The default is
+ Path to the <application>zstd</application> command. The default is
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
2022-04-20 21:38 ` Re: typos Justin Pryzby <[email protected]>
@ 2022-05-11 02:03 ` Justin Pryzby <[email protected]>
2022-05-11 06:41 ` Re: typos Michael Paquier <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Justin Pryzby @ 2022-05-11 02:03 UTC (permalink / raw)
To: pgsql-hackers
I found a bunch more typos; a couple from codespell, and several which are the
result of looking for previously-reported typos, like:
time git log origin --grep '[tT]ypo' --word-diff -U1 |grep -Eo '\[-[[:lower:]]+-\]' |sed 's/^\[-//; s/-\]$//' |sort -u |grep -Fxvwf /usr/share/dict/words >badwords.txt
time grep -rhoFwf badwords.txt doc |sort -u >not-badwords.txt
time grep -Fxvwf not-badwords.txt ./badwords.txt >./badwords.txt.new
time grep -rhoIFwf ./badwords.txt.new src --incl='*.[chly]' --incl='*.p[lm]' |sort |uniq -c |sort -nr |less
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
2022-04-20 21:38 ` Re: typos Justin Pryzby <[email protected]>
2022-05-11 02:03 ` Re: typos Justin Pryzby <[email protected]>
@ 2022-05-11 06:41 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Michael Paquier @ 2022-05-11 06:41 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: pgsql-hackers
On Tue, May 10, 2022 at 09:03:34PM -0500, Justin Pryzby wrote:
> I found a bunch more typos; a couple from codespell, and several which are the
> result of looking for previously-reported typos, like:
Thanks, applied 0002.
Regarding 0001, I don't really know which one of {AND,OR}ed or
{AND,OR}-ed is better. Note that the code prefers the former, but
your patch changes the docs to use the latter.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
@ 2022-04-21 04:36 ` Michael Paquier <[email protected]>
2022-04-21 13:59 ` Re: typos Peter Eisentraut <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2022-04-21 04:36 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: Justin Pryzby <[email protected]>; David Rowley <[email protected]>; pgsql-hackers; Fabien COELHO <[email protected]>; Amit Kapila <[email protected]>
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
> So the attached.
>
> --- a/doc/src/sgml/install-windows.sgml
> +++ b/doc/src/sgml/install-windows.sgml
> @@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m";
> </varlistentry>
>
> <varlistentry>
> - <term><productname>ZSTD</productname></term>
> + <term><productname>Zstd</productname></term>
> <listitem><para>
> - Required for supporting <productname>ZSTD</productname> compression
> + Required for supporting <productname>Zstd</productname> compression
Looking at the zstd project itself for reference or just wiki-sensei,
I don't think that this is correct:
https://github.com/facebook/zstd
https://en.wikipedia.org/wiki/Zstd
Their README uses "zstd" in lower-case, while "Zstd" (first letter
upper-case) is used at the beginning of a sentence.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: typos
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
2022-04-21 04:36 ` Re: typos Michael Paquier <[email protected]>
@ 2022-04-21 13:59 ` Peter Eisentraut <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2022-04-21 13:59 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; Alvaro Herrera <[email protected]>; +Cc: Justin Pryzby <[email protected]>; David Rowley <[email protected]>; pgsql-hackers; Fabien COELHO <[email protected]>; Amit Kapila <[email protected]>
On 21.04.22 06:36, Michael Paquier wrote:
> On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
>> So the attached.
>>
>> --- a/doc/src/sgml/install-windows.sgml
>> +++ b/doc/src/sgml/install-windows.sgml
>> @@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m";
>> </varlistentry>
>>
>> <varlistentry>
>> - <term><productname>ZSTD</productname></term>
>> + <term><productname>Zstd</productname></term>
>> <listitem><para>
>> - Required for supporting <productname>ZSTD</productname> compression
>> + Required for supporting <productname>Zstd</productname> compression
>
> Looking at the zstd project itself for reference or just wiki-sensei,
> I don't think that this is correct:
> https://github.com/facebook/zstd
> https://en.wikipedia.org/wiki/Zstd
>
> Their README uses "zstd" in lower-case, while "Zstd" (first letter
> upper-case) is used at the beginning of a sentence.
It is referred to as "Zstandard" at both of those places. Maybe we
should use that. That is also easier to pronounce.
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2022-05-11 06:41 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 22:16 [PATCH v6 05/10] doc: s/evade/avoid/ Justin Pryzby <[email protected]>
2022-04-20 21:32 Re: typos Alvaro Herrera <[email protected]>
2022-04-20 21:38 ` Re: typos Justin Pryzby <[email protected]>
2022-05-11 02:03 ` Re: typos Justin Pryzby <[email protected]>
2022-05-11 06:41 ` Re: typos Michael Paquier <[email protected]>
2022-04-21 04:36 ` Re: typos Michael Paquier <[email protected]>
2022-04-21 13:59 ` Re: typos Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox