Date: Mon, 25 Apr 2022 13:19:47 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Shinya Kato <Shinya11.Kato@oss.nttdata.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Add --{no-,}bypassrls flags to createuser
Message-ID: <20220425201947.GA2935432@nathanxps13>
References: <850d0579cdad54a37fd777d6b11421ec@oss.nttdata.com>
 <20220415.153341.594036939490942414.horikyota.ntt@gmail.com>
 <CA+TgmoYO090Xkwp--vCo0FGrFZBTG=V7wE3EF5WEAPcrFTpbSg@mail.gmail.com>
 <20220419.105012.1677795152077894444.horikyota.ntt@gmail.com>
 <CA+TgmoaTNwzZ6LXgaMzB03J6iijAPqSys39xHd7e6Fwb__3V1g@mail.gmail.com>
 <YmDdxXPVNR8Km0v/@paquier.xyz>
 <CA+TgmoYeZg5deFv+r-dDvWQLuSOiTNAUbcsx4kY2XhGSeGz7FA@mail.gmail.com>
 <CAKFQuwa7kaFmEMszAAkpy-RiYZjW4M3MGo4-EidExZbOAgwQkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAKFQuwa7kaFmEMszAAkpy-RiYZjW4M3MGo4-EidExZbOAgwQkg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220425201947.GA2935432%40nathanxps13>
Precedence: bulk

On Thu, Apr 21, 2022 at 01:21:57PM -0700, David G. Johnston wrote:
> I'm ok with -m/--member as well (like with --role only one role can be
> specified per switch instance so member, not membership, the later meaning,
> at least for me, the collective).
> 
> That -m doesn't match --role-to is no worse than -g not matching --role, a
> short option seems worthwhile, and the -m (membership) mnemonic should be
> simple to pick-up.
> 
> I don't see the addition of "-name" to the option name being beneficial.
> 
> Yes, the standard doesn't use the "TO" prefix for "ROLE" - but taking that
> liberty for consistency here is very appealing and there isn't another SQL
> clause that it would be confused with.

+1 for "member".  It might not be perfect, but IMO it's the clearest
option.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com