Date: Wed, 27 Apr 2022 09:53:58 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>,
	Nikita Glukhov <n.gluhov@postgrespro.ru>,
	pgsql-hackers@postgresql.org, Dmitry Dolgov <9erthalion6@gmail.com>,
	Oleg Bartunov <obartunov@postgrespro.ru>,
	Erik Rijkers <er@xs4all.nl>
Subject: cirrus: run macos with COPY_PARSE_PLAN_TREES etc
Message-ID: <20220427145358.GQ10173@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: <https://www.postgresql.org/message-id/20220427145358.GQ10173%40telsasoft.com>
Precedence: bulk

fork: <20220325000933.vgazz7pjk2ytj65d@alap3.anarazel.de>

On Thu, Mar 24, 2022 at 05:09:33PM -0700, Andres Freund wrote:
> On 2022-03-24 18:51:30 -0400, Andrew Dunstan wrote:
> > I wonder if we should add these compile flags to the cfbot's setup?
> 
> Yes, I think we should. There's a bit of discussion of that in and below
> https://postgr.es/m/20220213051937.GO31460%40telsasoft.com - that veered a bit
> of course, so I haven't done anything about it yet.  Perhaps one build
> COPY_PARSE_PLAN_TREES and RAW_EXPRESSION_COVERAGE_TEST another
> WRITE_READ_PARSE_PLAN_TREES?  We should add the slower to the macos build,
> that's plenty fast and I'm intending to slow the linux test by using ubsan,
> which works better on linux.

Why would you put them on different tasks ?
to avoid slowing down one task too much ?
That doesn't seem to be an issue, at least for those three defines.

What about adding RELCACHE_FORCE_RELEASE, too ?
Even with that, macos is only ~1min slower.

https://cirrus-ci.com/task/5456727205216256

commit 53480b8db63b5cd2476142e28ed3f9fe8480f9f3
Author: Justin Pryzby <pryzbyj@telsasoft.com>
Date:   Thu Apr 14 06:27:07 2022 -0500

    cirrus/macos: enable various runtime checks
    
    cirrus CI can take a while to be schedule on macos, but the instance always has
    many cores, so this is a good platform to enable options which will slow it
    down.
    
    See:
    https://www.postgresql.org/message-id/20211217193159.pwrelhiyx7kevgsn@alap3.anarazel.de
    https://www.postgresql.org/message-id/20211213211223.vkgg3wwiss2tragj%40alap3.anarazel.de
    https://www.postgresql.org/message-id/CAH2-WzmevBhKNEtqX3N-Tkb0gVBHH62C0KfeTxXzqYES_PiFiA%40mail.gmail.com
    https://www.postgresql.org/message-id/20220325000933.vgazz7pjk2ytj65d@alap3.anarazel.de
    
    ci-os-only: macos

diff --git a/.cirrus.yml b/.cirrus.yml
index e0264929c74..4a6511115fc 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -337,6 +337,7 @@ task:
       CLANG="ccache ${brewpath}/llvm/bin/ccache" \
       CFLAGS="-Og -ggdb" \
       CXXFLAGS="-Og -ggdb" \
+      CPPFLAGS="-DRELCACHE_FORCE_RELEASE -DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST" \
       \
       LLVM_CONFIG=${brewpath}/llvm/bin/llvm-config \
       PYTHON=python3