Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njxrT-0002CB-Fw for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Apr 2022 06:42:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1njxrS-0006Sn-8O for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Apr 2022 06:42:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njxrR-0006Sc-VJ for pgsql-hackers@lists.postgresql.org; Thu, 28 Apr 2022 06:42:45 +0000 Received: from mx0b-0050f201.pphosted.com ([148.163.141.54]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njxrK-0006TT-Ou for pgsql-hackers@lists.postgresql.org; Thu, 28 Apr 2022 06:42:45 +0000 Received: from pps.filterd (m0203370.ppops.net [127.0.0.1]) by mx0b-0050f201.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23RLrms4026270 for ; Thu, 28 Apr 2022 15:42:37 +0900 Received: from sraihe.sra.co.jp (sraihe.sra.co.jp [221.255.117.38]) by mx0b-0050f201.pphosted.com (PPS) with ESMTP id 3fky7tx9h2-1 for ; Thu, 28 Apr 2022 15:42:36 +0900 Received: from srascb.sra.co.jp (srascb [133.137.8.65]) by sraihe.sra.co.jp (Postfix) with ESMTP id 1832D2A6865 for ; Thu, 28 Apr 2022 15:42:36 +0900 (JST) Received: from sranhm.sra.co.jp (osspc47 [133.137.174.164]) by srascb.sra.co.jp (Postfix) with ESMTP id 087245802BB for ; Thu, 28 Apr 2022 15:42:36 +0900 (JST) Received: from yugon-CFSV7-1 (sraihb-hub.sra.co.jp [133.137.8.6]) by sranhm.sra.co.jp (Postfix) with SMTP id 627D5341521; Thu, 28 Apr 2022 15:42:32 +0900 (JST) Date: Thu, 28 Apr 2022 15:40:11 +0900 From: Yugo NAGATA To: Greg Stark Cc: PostgreSQL Hackers , Zhihong Yu , Julien Rouhaud , r.takahashi_2@fujitsu.com, vignesh C , Tom Lane , Andrew Dunstan , Andy Fan , Tatsuo Ishii , Thomas Munro Subject: Re: Implementing Incremental View Maintenance Message-Id: <20220428154011.871015d8e0626d79c65e2c5f@sraoss.co.jp> In-Reply-To: References: <20210517133646.04c3d9ed232af22c0f290ebc@sraoss.co.jp> <20210922191227.09a9891ec9da5ebe67475f1f@sraoss.co.jp> <20211125163710.2f32ae3d4be5d5f9ade020b6@sraoss.co.jp> <20220113102342.mlhknuy6ppypflq3@jrouhaud> <20220204012548.788837b8b3d76aa57022ba9c@sraoss.co.jp> <20220204014806.d29d5d923a0c51ad723cedb6@sraoss.co.jp> <20220314192616.8d15d05d71b1e426c4bfaf96@sraoss.co.jp> <20220422112939.dc2a3a4e559defc9b43024d0@sraoss.co.jp> <20220422145801.2a1ded1096bbe5cec983cfdc@sraoss.co.jp> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FLTp0GUSv4wbTBaT0nvUsofV6f02G0LA X-Proofpoint-ORIG-GUID: FLTp0GUSv4wbTBaT0nvUsofV6f02G0LA X-Proofpoint-Virus-Version: vendor=nai engine=6400 definitions=10330 signatures=694622 X-Proofpoint-Spam-Details: rule=spam_low_notspam policy=spam_low score=0 priorityscore=1501 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=637 malwarescore=0 bulkscore=0 clxscore=1034 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280039 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Greg, On Sat, 23 Apr 2022 08:18:01 +0200 Greg Stark wrote: > I'm trying to figure out how to get this feature more attention. Everyone > agrees it would be a huge help but it's a scary patch to review. > > I wonder if it would be helpful to have a kind of "readers guide" > explanation of the patches to help a reviewer understand what the point of > each patch is and how the whole system works? I think Andres and Robert > have both taken that approach before with big patches and it really helped > imho. Thank you very much for your suggestion! Following your advice, I am going to write a readers guide referring to the past posts of Andres and Rebert. Regards, Yugo Nagata -- Yugo NAGATA