Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl4br-0000cT-7A for pgsql-hackers@arkaria.postgresql.org; Sun, 01 May 2022 08:07:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nl4bp-0000Eg-JV for pgsql-hackers@arkaria.postgresql.org; Sun, 01 May 2022 08:07:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl4bp-0000EX-2j for pgsql-hackers@lists.postgresql.org; Sun, 01 May 2022 08:07:13 +0000 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nl4bm-00029T-TV for pgsql-hackers@postgresql.org; Sun, 01 May 2022 08:07:11 +0000 Received: by mail-qv1-xf30.google.com with SMTP id kk28so636836qvb.3 for ; Sun, 01 May 2022 01:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Td/ejaJ983OFhqJ4W/WMczi9wwGzHu7dlY/GPn5pT/0=; b=dL5B1KD+5ixXEuDwDndXCskqwdSUPvMzpAKhWwr13wv6o1u++4oWDlDvYbrUHGODbw p2sE5jLFQdLXUGEDWHPhGQBVbfJiWL1dXBh6un4YDMj6JJaEFO+IsWH2X1mf8RPGjfTQ sQ4dm+WwuoVNjizlVNbw0PgLuwiwvDUu1IJPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=Td/ejaJ983OFhqJ4W/WMczi9wwGzHu7dlY/GPn5pT/0=; b=W8mklqQqxXHBtIvWDqkt9RcwKX9xRW8MbEsqW8EUjrFPtRmm1jgN09K1rtrCpzRhBE TtqVTkyOdixgtWUjp8LeNMmGt6dy3E4nf6d1NaVZ5wQpzOhrIo3l9ijmpgFcgKV84buM d3z4PFQ2TF00OQEJdpxFvGjp7/yxD4SwJbDGyQbMea5sbeZdV8aIkGoylfBDMIvgJc++ TsRlissWzff88I0OUCnxKBcjQBbst5HoYCXx9BSdGfB/2EXymyXge5oV2RBtwFvukxB8 YRTs+S/ugOFLtlhOh7vWEeLgO22XDAsVahJmuQP3Oh75LgyqnJAxpoMjnQWMuqaVKPh+ bknQ== X-Gm-Message-State: AOAM531IrLY/8yzexqll88UoyAR0K0BPCsqjuw3nzevN1Gy0leKpFzPq yq8Wqh40XdQlmrRqYzNOBTA4Mg== X-Google-Smtp-Source: ABdhPJyyN4yaZrKmB/kTiGd4LcdsmYsH1i05V+bGoPuTnLssEJDsinbzI7Ei/wNdJrD4wE/dywMREw== X-Received: by 2002:a05:6214:761:b0:441:196:795e with SMTP id f1-20020a056214076100b004410196795emr5337556qvz.67.1651392429565; Sun, 01 May 2022 01:07:09 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id y21-20020ac87095000000b002f39b99f699sm2271746qto.51.2022.05.01.01.07.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 May 2022 01:07:09 -0700 (PDT) Date: Sun, 1 May 2022 01:07:06 -0700 From: Noah Misch To: pchampion@vmware.com, daniel@yesql.se Cc: pgsql-hackers@postgresql.org Subject: testclient.exe installed under MSVC Message-ID: <20220501080706.GA1542365@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk My annual audit for executables missing Windows icons turned up these: pginstall/bin/testclient.exe pginstall/bin/uri-regress.exe I was going to add the icons, but I felt the testclient.exe name is too generic-sounding to be installed. testclient originated in commit ebc8b7d. I recommend ceasing to install both programs under MSVC. (The GNU make build system does not install them.) If that's unwanted for some reason, could you rename testclient to something like libpq_test? Thanks, nm