Date: Tue, 3 May 2022 09:46:10 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Message-ID: <202205030746.pfpbpywy7xp7@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/202205030746.pfpbpywy7xp7%40alvherre.pgsql>
Precedence: bulk

On 2022-May-02, Andres Freund wrote:

> > > pgindent uses some crazy formatting nearby:
> > >         SendRecoveryConflictWithBufferPin(
> > >                                           PROCSIG_RECOVERY_CONFLICT_STARTUP_DEADLOCK);
> > 
> > I do not believe that that line break is pgindent's fault.
> 
> Oh - I'm fairly certain I've seen pgindent do that in the past. But you're
> right, it's not. Perhaps it was an older version of pgindent?

No, it's never done that.  We used to fold lines that way manually,
because pgindent used to push the argument to the left, but that changed
at commit 382ceffdf7f6.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria.  Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)