Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noey7-0001kf-4u for pgsql-hackers@arkaria.postgresql.org; Wed, 11 May 2022 05:33:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1noey5-0001NN-Ll for pgsql-hackers@arkaria.postgresql.org; Wed, 11 May 2022 05:33:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noey5-0001HP-5A for pgsql-hackers@lists.postgresql.org; Wed, 11 May 2022 05:33:01 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noey2-00070D-SY for pgsql-hackers@lists.postgresql.org; Wed, 11 May 2022 05:33:00 +0000 Received: by mail-oi1-x22e.google.com with SMTP id e189so1472224oia.8 for ; Tue, 10 May 2022 22:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TgwRSOMlBTAK5FAXYXMy7y/b47KlyALKg8V75SUTHso=; b=LsaDBCZLxEEpeJ9JJPYo3utAo5AN+zH67ijRLomEFnlhFpP9OgMtkKzrFpTIomho0Y CNT8yILGIyKuCQherfbRk94Pv3wJrZq+0K9Xv0UwU40YSdBibJ8T+JzdIMa7kRhSBpyT RmUMhok4RmxZmC2TdzoASvalZ+ZiNJp1xPvr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TgwRSOMlBTAK5FAXYXMy7y/b47KlyALKg8V75SUTHso=; b=SAXLCMBovSzh57jVPJ5sC2NzPnC3LVLx4Sq/8lekJWq5MGbJ0Z6EJhjapVvt+1evuG a8efNvVLm0NiQas+TBogrt+Pgskcm4mV/Y4E17TibxfE9umUQgizW/1XHJx0N/mynHU+ HpPWn9EByFmqcIop16djiAqOXwi7VvQNoFUh9ggpjepCHvjIzZ55XCiWCwOlYczIPfSF vqg0iefwZoB4CtVWiHiDAQJLAY9W/eRP4l8RmxjMAt4CQR/eZc4aqOrYuqTtaKJ8SDQl KvNrFkyRvcW5OrKjBokE2Hmj8DTA/XUpruDBdULAvm4liQVgVE8NHSbQr07Ozw6Jot25 emSA== X-Gm-Message-State: AOAM53259Cah78Yz+cd5kLu+14S/sJr0TNLKpTdceKfFb/0b0z9GJH+G wtLia5XJC19f8qUH/683mqvK2A== X-Google-Smtp-Source: ABdhPJxBzT3oL16WHlWAyLms7P8sRFJbU/JBTO57WLGtXDrM/JKvehvv5/SGkaxQH5bBZSC7c8GGkg== X-Received: by 2002:aca:4bc7:0:b0:325:aa1d:f4f7 with SMTP id y190-20020aca4bc7000000b00325aa1df4f7mr1669049oia.160.1652247178358; Tue, 10 May 2022 22:32:58 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id t62-20020aca5f41000000b00325cda1ff96sm413487oib.21.2022.05.10.22.32.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 May 2022 22:32:57 -0700 (PDT) Date: Tue, 10 May 2022 22:32:55 -0700 From: Noah Misch To: Michael Paquier Cc: Tom Lane , Andres Freund , Thomas Munro , Julien Rouhaud , Andrew Dunstan , Postgres hackers Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set Message-ID: <20220511053255.GA2578591@rfd.leadboat.com> References: <502623.1648702814@sss.pgh.pa.us> <20220331053616.u446wsr732quuzer@alap3.anarazel.de> <547429.1648734590@sss.pgh.pa.us> <20220502042718.GB1565149@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 11, 2022 at 10:29:44AM +0900, Michael Paquier wrote: > On Mon, May 09, 2022 at 12:18:39PM +0900, Michael Paquier wrote: > > All these fixes lead me to the attached patch. > > I have applied this stuff as of 7dd3ee5, in time for beta1, and closed > the open item. One difference is that I've added one backslash > surrounding the double quote at the beginning *and* the end of the > database name in the patch. However, the original case was different, > with: > - At the beginning of the database name, one backslash before and > after the double quote. > - At the end of the database name, two backslaces before the double > quote and three after the double quote. Why did you discontinue testing the longstanding test database name?