public inbox for [email protected]  
help / color / mirror / Atom feed
From: Justin Pryzby <[email protected]>
To: John Naylor <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: [email protected]
Cc: Robert Haas <[email protected]>
Subject: Re: A qsort template
Date: Thu, 19 May 2022 15:12:54 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFBsxsHOUf6pDZOXpHTfV1H_TwLDaKGfRwhAWO=BL53sfTgt9w@mail.gmail.com>
References: <[email protected]>
	<CA+hUKGLvvAiHy9AHPUWFR1uLskATvqkofjD7nxgcPtJD1tdojQ@mail.gmail.com>
	<CA+hUKGJRbzaAOUtBUcjF5hLtaSHnJUqXmtiaLEoi53zeWSizeA@mail.gmail.com>
	<CAApHDvoO0sJiGgqK3vx=XX4TF6qik3YbLT-XAfvQLW6uq=t-NQ@mail.gmail.com>
	<CAFBsxsEJxfQcMfCjGi+Vbkqf0SnpCW65vfh4SMySYo8NaBTLhg@mail.gmail.com>
	<CAApHDvqWQJrAwLBveQLTfcB46NSer7qRLTe_NJF2cPuXziu4oA@mail.gmail.com>
	<CAFBsxsH4RGpNB+O17FKnYApOmo0h+434iis+-9G6S3-p-krpOA@mail.gmail.com>
	<CAFBsxsEVzWYhjpXfoBKOGro--dfy9Xb5O_qU_hikHrYoOjsysg@mail.gmail.com>
	<CAApHDvr8bhkgsdOxhUUngX5n72UkJ6NTjprSGthX_CX1KWxZPg@mail.gmail.com>
	<CAFBsxsHOUf6pDZOXpHTfV1H_TwLDaKGfRwhAWO=BL53sfTgt9w@mail.gmail.com>

On Fri, Apr 22, 2022 at 11:37:29AM +0700, John Naylor wrote:
> On Fri, Apr 22, 2022 at 11:13 AM David Rowley <[email protected]> wrote:
> >
> > On Thu, 21 Apr 2022 at 19:09, John Naylor <[email protected]> wrote:
> > > I intend to commit David's v2 fix next week, unless there are
> > > objections, or unless he beats me to it.
> >
> > I wasn't sure if you wanted to handle it or not, but I don't mind
> > doing it, so I just pushed it after a small adjustment to a comment.
> 
> Thank you!

Should these debug lines be removed ?

elog(DEBUG1, "qsort_tuple");

Perhaps if I ask for debug output, I shouldn't be surprised if it changes
between major releases - but I still found this surprising.

I'm sure it's useful during development and maybe during beta.  It could even
make sense if it were shown during regression tests (preferably at DEBUG2).
But right now it's not.  is that

ts=# \dt
DEBUG:  qsort_tuple
List of relations

-- 
Justin





view thread (78+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: A qsort template
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox